From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932230AbdJaB3k (ORCPT ); Mon, 30 Oct 2017 21:29:40 -0400 Received: from mail-bl2nam02on0045.outbound.protection.outlook.com ([104.47.38.45]:64703 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753221AbdJaB3h (ORCPT ); Mon, 30 Oct 2017 21:29:37 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171020023413.122280-14-brijesh.singh@amd.com> <20171029204825.18260-1-brijesh.singh@amd.com> <20171030172150.3eibiqr44i43zbvd@pd.tnic> <1e89d599-b1d2-bb16-92f4-0409ee0a6ea0@amd.com> <20171030175708.3w3sfzbtqdvmqs62@pd.tnic> From: Brijesh Singh Message-ID: Date: Mon, 30 Oct 2017 20:29:25 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171030175708.3w3sfzbtqdvmqs62@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CO2PR05CA0009.namprd05.prod.outlook.com (10.166.88.147) To CY1PR12MB0152.namprd12.prod.outlook.com (10.161.173.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9545dbbe-df99-469b-1e13-08d51ffed5e8 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(48565401081)(2017052603199);SRVR:CY1PR12MB0152; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;3:SRSTU6WKDl/dtwT5YMd1goXIt7Yq0NHmMwOSmNy+0e1hnK3L3OKGdzHMRWa9dfpDB1A+Zf9o9/snyGyOIpR7MqbHqXuWB0zK76bH+1WE2Qo0X30OzilD0Pd1KCR5Fu+45ih2NcVJ+9iGpA3WTSro8MIUV0H4E26a8YwOngFIBee+CEl3tzvM5q3/jDNgO8RlZG3RIIfbP4/yhmYgUQ/90mLyxRk2gbeic7G0n3wlq8UW+xmkVJHMoOSdTJAI6ArI;25:kuk6V/WjNRbBDgkEzqcoiNqc1B1oML28lyiNjoNti/HPKASa63ySyACYKTFEOBQOtBOVqWt91mWK+YNBlyKOW7K3j9+t4RIhZVGrCjYgoi8RcnSOu+YmjUc9Z1oqJMlkkH2wui5uepC+CFAM/Rruxde4Fkfh8oxRw9UE+B1Ha6DJGzVlFvfdh1VD23kUueXiwySv7CQF8N9a68e7UIvlbS8ccdSf0m+6V3l74DMtj3+3Q3GESw9PkIwtmOORfyil5ekXbL/cFwe5qFMu+FJ5alA+uzKs7ulqvfcv/fm5i3I65QNoTzMoQ3rKPsQ/B8PyGvI17YvmhBtYRCFrtObAiQ==;31:whC/5sR+kfkrmuqGAlW410hgX7+dpAZcZ28go0qrZvlNkNaPHS3KBJUl1fycrqej+tJYJTAF29LuX0n1QRv4vKQYhmqr5zj2tBQVfKDkmHYA31QM1MlfF/jUwAx0OvHYBlH8bib3tutC4A87BUxsjHybZkoi8ZzdltCa7Z3TOPlun1BWTXnvwgfL2Do5ZYRog1ES/yWntU2tU2Z/cLRlIloI4vGM9E4s/KkZcA2zXXU= X-MS-TrafficTypeDiagnostic: CY1PR12MB0152: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:uWaz/A5ur7ph7GAinpj7/dk6RlFnicqNRXDIh1ZoLrKykKjuRAV2r5HxyRBbxNWFq46tSOGnAp6J+6n3gVB5vRMvP7Y0gNNsHdYuY4d1Ho23tIP+Gp0zb0+0o8RcpGkEn8lvoL7Lzdkq2LC8MsLmL0ciB+EufPCChBWaxnh+DhX1tWpn8n+HD1ZhLfCNqf4o9NUNniGCrpgnDoOl7OwvC2r2VxVKJjIacjblSisuqSKMxavu6IkDXZog+P70xqtIyto0wTZ+rNTNn6m21f8fl2AYugjn3r0DZGMDKHyUgyBUbmddPHSBQORtWyD4O2QB8VSJDX8gW9mNBJ2CDe5ANSzMcXV+qFudR6iwjahT155KAzothPtXekh7zQHNnNoM2hayY+baIR1tS/k4+Lc5gx3paD8uruAzQ+Aomp1ssF73/y7Z8J6el2o97KzC4RaQ+Ms2pESz9HpHOwWs2++ZOpAevAyjvWfzHb+vIXEfOYxSg4tS4FW/T/wfWgARFFFz;4:LWZKyd0Jvx+jLuTHoq9IWnR0tV72t9mVgit70kjhqET2C3S8exHoPCWav5Ub58XXlhTl1U8ZXrNo8pOqN1If8aENc2DtHkFEWgbr3Sy5+CGceuBjDJ86JR0ACnqsoPaQjuVeYM5jp/bwq17CRaj4fDrfWqz25xYJgCMZ0XuL+T5CtUWpkiZS2J6tAhxBYXUfwA3LNwJkKa+6+Zi/7+Sy46Wv197CtgjY//zp4IFUfR0rquXLkifuRRP/8AGGBYcm1je8vON5ZBsyUPG7sCI5cg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231020)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0152; X-Forefront-PRVS: 04772EA191 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(199003)(24454002)(189002)(2870700001)(65956001)(53416004)(65806001)(6666003)(189998001)(36756003)(8676002)(8936002)(81166006)(2950100002)(6116002)(3846002)(47776003)(65826007)(81156014)(6916009)(54906003)(58126008)(97736004)(93886005)(478600001)(53546010)(66066001)(2906002)(229853002)(6246003)(83506002)(31686004)(54356999)(50986999)(53936002)(101416001)(16526018)(64126003)(316002)(5660300001)(6486002)(76176999)(4326008)(31696002)(33646002)(305945005)(86362001)(25786009)(7736002)(68736007)(50466002)(106356001)(23676003)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0152;H:wsp101240wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUyOzIzOmcvdDVXeHNlRXAwbGxuakx3MlY5T0ljcHc3?= =?utf-8?B?TkhKbC8rZTZxbXNDOFdmOEg5L2w3Y2VpdmJhT1R5RStOWkNtejFIUzRlTXdr?= =?utf-8?B?bVllRkhvMEFCc0JzUGd6aVFuTmZ2MVZheU5uL2xtcEFTeDU3VXpiTTVCZWEz?= =?utf-8?B?QTM1dXF2UHltcmNJeVh1NURRU2p3emtmY0dzMzBTQ1lyeEJHSTRBVWxxcGtr?= =?utf-8?B?cXI4WmJ0Um0zTlRQL3RLQXUxbGhrRmJxYTJSblA2dXJYV3NBSmlYNk4wM3RK?= =?utf-8?B?MVN1RlEwQ0RXU0NmL0NvMFJHbGRDMFNpWTg0M2t0bElFcGw1OXlDZXBhNFcx?= =?utf-8?B?d1pRdWZnOU9ZUWV0Y2FnS3Y1TWowNWZGdEZ0M3RvRkdwcDg0YmlKeUZ6Q1dH?= =?utf-8?B?bjhQa0hjS3l4NTlzbVBQUm9sam9MRlRzNVQ1SURpNDVvRWp6eFl6NHhmeVA4?= =?utf-8?B?ei92ZGF4SkY4L3J2bUx0ZEoxdXNRL0RkS1RxS01kZy9pU2x0aGZoRGdjNW44?= =?utf-8?B?bDFxZTdwTzVneVp4MWh6SW1aUkl1QzE2SmhScnBTV2hKMmg0OU9idDhKanI1?= =?utf-8?B?NjNWSW1mc3BDQ0s1M2l1eVBsaFJtUkVnMDMwdTEzN3JvZGRUbElyRFpTSVls?= =?utf-8?B?cTVGcDRhaXNlQXBkRlR6S1dyV1hwbUR5NFh5ekRxZnVjNXk5MDZIV2xJcnBI?= =?utf-8?B?dkRPT2QxV0t4c2tlam1yUSt3SWhxcGU1bWJDeklSTDFOSmxBQXc5eUJ2cXVr?= =?utf-8?B?elluTVRVMDI0NG1BQ2NMVUd6WndwZ2JXK1cwdDQ2TEM3NXZYWk5WbjJua01x?= =?utf-8?B?TlhqcmFseXRtWk9XWjJBWloxdEtQQ1ZVU1NPRGNUcU41NGlNQ2J5a2tJYjZX?= =?utf-8?B?aWVsTnhlUmxJNVpqWjlMbENsWitUUE82ME0vTkpJRzQxWU82c24xS3RMQ1R5?= =?utf-8?B?RXZCR0FrV3JYalE5N3hOd0thNmJhNTJDaHhkQ1BvQ1dua2NrWUZhR1NpOU5S?= =?utf-8?B?OUR6TDdWTG1EN2JYczgxLzJpai94T1UwcVJ4OVRnRnhrck5WQnZlOTRLTXpW?= =?utf-8?B?NlpEVUdlRzMyWWxtVFpLZ2hKbDNBeDNrTDFCc0pMM1RZMEVuYkZsSUdEVTR4?= =?utf-8?B?Q24za3FkZmw1MG8xKzZXQ3Z0WEMyYmhGZlU1OFBpcnVWa2R4amhCbk03TC91?= =?utf-8?B?alZ3eFR4Ny80Zk1OeXNtQTdmNVFTK0g3OTMrc015Z1dNNWpUY2N2SXFtUTdh?= =?utf-8?B?a0pjYkFPRWxiNjE4MEtYTFUxdEQrc2V6WUlLT3FBTmJ3Rk55RVYzV29jL0hM?= =?utf-8?B?TytORDErejVzTjZVcmdDUXQ5ODBxWGJrYVExTkl0djY4bmxRVk9iYkM3M2Zy?= =?utf-8?B?VU9RTW83aElZTFBOVHl2VUpIM2VwVVhkWFZZak1tWWFzWWFhVXRLQkZrTGM5?= =?utf-8?B?blZRcWNQaFpSSFFiSHhXWHdMOGFSOElLcW11bXpGQWh2VUhRcDFGMVFxQnda?= =?utf-8?B?cHdJOXNnaEhPa2hmS0pBTWkybkFXcFY2cHQyMDRSc0lkT3FMUU5pOHk0U25z?= =?utf-8?B?M0x1NzZSa0sxemZRTTZmY08raEM4OUp6RGRhdHlXVG16QWE3NXhsWTc0R01r?= =?utf-8?B?bE83MWJvY2UyY2taOSt5ckRIR3JnWjlMMVVDYnZzQ2lMdmtlRUU1a0ZITXBM?= =?utf-8?B?NWwzUkJmMndSRjZZd2lGOGdBbmZTWVBkZHFOWlRxRUJ5U0loKzFZUjJ3ZjlL?= =?utf-8?B?RGtGMlp6WFhpQW9tL3FETWdjZWNsOHFxNkpRY0ZONytvaFZBRnBoVlJmSEl2?= =?utf-8?B?SUtPb2FFaWJXdE1nTFgrNW5oWEJ6dWlmY0lRejNibEw5cWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;6:iOn77YkZCwis0FftN5V/K6Dp+swoZg5KEih/AQnJ2IEdnB3flJIdMINMjlfZmajvuwO3GvxrNIaymPYJ/0tHo35zQAr3C3Abj7031vPe3+tjQfsrQmJxsYY3hq0Jrvuyo0vdB34cdaGkr5wn3MUY20COeF33lqq7YUZQOBShIu5DF44e7Kcv4xaiQ5l06/jcxk2DLBXLTO9g/AEqhizQuEPdSb3j1olPMPvzyPRuWm6A2jnrqx65io8a1kTQ86+meMGBRrBVOhewJnCoHh+SuPDYGwy2lGfUv6J2WSynu66lxROedtgRqL2y9AZNCmUS5hr6IC+UFnNDsQnoEygJusUn9g60H5Avb+woJE2vCDM=;5:6QIycuDSy2U2SU/A2Hy8cI+SxjmGW5shkebJHTzI0mJI4vhdXiO3Q6LFhSjRMN2KDCu4GivIkNgcIKiJrhKOB5jdU+F/4kfL95ye4/d7sQGB7XrQyCoTBrAYlX+dLyr/FKHeV4q6gR4ZJiLHUMr3JU153iXJa32UWAT0JQmQ3TE=;24:k1a3rqBKV+o/tk1WvHZN4wHDdCPScKiU7PN76nK/tdGif0y83jDBXUx4vYF9En3ruJFmMiFVZEO9qy7rJW2rIcz+vch+d0zNPZDk2lPFQiY=;7:6LMd1QsM/V3BHlsqcv1bnfRJ/rfX3WZq0s++hUxUolRxrFbIP4JNleT4+W4JodUm8egNzkyqWQYqKgQV25Jzb72o47G7Cimr/c7q59+JWIklPDgA/dj3BY8Z9cD3oxS7XeKY+md555u70XDQVMvV4mF+zCS0NS14a2kVXTpnzvWTAgf2RilEprDV18JfLODVAmxB47kAjuT/5Y/9dPLQyNX8lrR45qDOFMIASqpwITru3OeBdbm2AfLSsrDXdFsT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:ktVgkYdYNbI2Q2Gavw1Lq4lrBQ7jh+BGEoM6iNHe4HVhr/KWVmUtV42bZrSwZUJ+8rsc4N6HS44USO7hxO+Rjt4FDOey7OV12FfqlwM/UkzXxkQueI2ysCKE0z8fkCblJ4VNKi8HrEH2+G6DuNFMdf3pqPnx/Xpkvnzz7cqMA7DuagEaSzb8gP4FMblqYqlSkohcnRk+AiygfG83rvXnubn4bVDHsEF8KidaWSOYen3eQxV+IBz5gZkQ+cG9SoX8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2017 01:29:30.0424 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9545dbbe-df99-469b-1e13-08d51ffed5e8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/17 12:57 PM, Borislav Petkov wrote: > On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: >> If the buffer is allocated on the stack then there is no guarantee that > static global is not allocated on the stack. Okay, Just tried static global with CONFIG_VMAP_STACK=y and I am getting wrong physical address with __pa. PSP command fails with error code "INVALID_ADDRESS". The same thing works fine with kmalloc() buffer. >> I can certainly move the allocation outside, but then it may increase the >> code size in other functions. If its not a big deal then I would prefer to >> keep what we have. > Avoiding repeated k*alloc calls is always a good thing. Actually kmalloc-ing 20 > bytes each time sounds like it is not worth the calling overhead to me. > To avoid repeated k*alloc calls, I could devm_kzalloc() these variable  during sev_init() and reuse them when needed.