From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charles Han <hanchunchao@inspur.com>,
mturquette@baylibre.com, sboyd@kernel.org,
duje.mihanovic@skole.hr
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: mmp: Fix NULL vs IS_ERR() check
Date: Fri, 7 Mar 2025 12:18:04 +0100 [thread overview]
Message-ID: <de6d8985-cd2e-494e-8be0-473612f1b363@kernel.org> (raw)
In-Reply-To: <20250307064708.209511-1-hanchunchao@inspur.com>
On 07/03/2025 07:47, Charles Han wrote:
> The devm_kzalloc() function returns NULL on error, not error pointers.
> Fix the check.
>
> Fixes: 03437e857b0a ("clk: mmp: Add Marvell PXA1908 APMU driver")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
> drivers/clk/mmp/clk-pxa1908-apmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This one might be actually correct (in other cases you were blindly
copying some code like returning -ENOMEM while code expects NULL).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-07 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 6:47 [PATCH] clk: mmp: Fix NULL vs IS_ERR() check Charles Han
2025-03-07 11:18 ` Krzysztof Kozlowski [this message]
2025-03-07 19:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6d8985-cd2e-494e-8be0-473612f1b363@kernel.org \
--to=krzk@kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=hanchunchao@inspur.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox