From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f226.google.com (mail-dy1-f226.google.com [74.125.82.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478C953E0B for ; Wed, 10 Jun 2026 22:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781128830; cv=none; b=Bq8g1JU3rGhMeZ6+Ekok1kehL/nY7Nm5AeeiVfK9ggRAvkM4shLe5DmYMp0ebmmUJhXWvlXRHJ3nRRWsTKG7nxiEwWnjuW+JEptpkEuDcrMEkjxlOmHaNMTdsEMXk1RseaHpbf7WSuNxC0VNjV2/nMIPzxf5/xtU6ioMuEP8ba8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781128830; c=relaxed/simple; bh=ramqzwgwaHkMeRRVPcQgWy7rGvDQoGV3tSSyz7US6HM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AyAkzT1rpI+eWAczo1JV8FLipFp2oEWycPpO6COOlLcr4vk9M8P0/ixqWVL4bdzVq8xvkRdZO4zNMlx3MB/lV8pSY3E/hqLDs55CgodLsnkbdIXqH81aMCHQkcQlCxk9J7vY8Pqt8EuaQ1ItP9vn76Jq3DIORkwMXpowHXqtXPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=E74d7BnH; arc=none smtp.client-ip=74.125.82.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="E74d7BnH" Received: by mail-dy1-f226.google.com with SMTP id 5a478bee46e88-307631dbfedso15711514eec.0 for ; Wed, 10 Jun 2026 15:00:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781128828; x=1781733628; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ifrWdwmMtnSLIzspQXoLqNd92UGj3f+HmaYSM1XCOxs=; b=iSKXFVXlJBv3bAV7AE/lyF3/rKhwwDbFOXKC/ZGwGEgPMdNQ4OWFK/gZaPz2QScT6G QbIoB5RLvnL2+K4QIUdHjTcQdJpvyvSbB/wUgEszNt/bMUx3hlg0JSD/l4CkcD3nZvlG lDAoJMe4wG0GnnMvg7wabsA0NE34WND7skpgPx9qemvdUhr2MmBhoMAiaSA6YQ6ArJuo qhpuwLhZwIgQ7hNvO6y3l7eTzZrXv89vloN1KHx5y+XcXyHoVIb2NHPy2g9ar/YeIpOM twNtNb00Qt4m0kpcC+nrOTBmoD5EqKZBPwGTYxV0S+gznBjsD3B2RMC+MT2sKxNzbHaz X0Tw== X-Forwarded-Encrypted: i=1; AFNElJ+h3X2fhnVhVBNlhtIXruo8ssL0npY0CUvRrI3FIqQPyaVd6MAHHxpgIkWU16kSrq+x4At7t6I4W0K6W2g=@vger.kernel.org X-Gm-Message-State: AOJu0YwhN405NgXnRowW2LhDifGojIhPSpFtu2+qhW2kYbhNEBlHa3PK xR0MlUHo3/OVwswlWgrqdoptwqIcro8w/dbskuGCGDUI84rizwvuyGxZ1kS+y379Vqzk4OCDjOh dWFFkL6tvACafKP8CYiIJjg7uvBLYnEYGUEVlfaFoCHXkZseQt9SngnM5OopT1On86X5PW3uwRR 1J49BA2wy6Wd1LHMWG2SNkIdrSbV/AZvbFyLQY6a4eMXu8aC0ZmUXm5sM2N0hxMg8Ohpp7bQv1b yx8Bskx1bNpA8fTLa7tNePT X-Gm-Gg: Acq92OHtPTi+XFfvMwAY6QyRbby75PtFmLsz/0PODu+S7oj+f0Pf9h25OUDbzSTxD5X W+mj/rT+AKoVs+nZOX2QS/WCR+YYhfoPUOELAz3ITLVL9LlUCi9dVYirZegS98vfxBoaeq+dbge NKYciibjLtSKH6YHBcdVuwYnTdVgpNDwzN/1Qsikw0+y3y8eeLiF3iWTVZCqtsDVqnSUh/TNE+v /1dJ/zzJp38KJFGmWDGImjlCeekmNhe396GB5aicl536zToAXdr+zJLnHvrL1DVXgdHmrzZOrC3 7kRRm5up+UjKo+BunuBORZelS2sJB3djIwrNsXU2/nt/Vt9eu8GKsYFrtNf/Li9DM4YPaMBEWUw LTbRtVi8cKMOingaf+a3vadOBj9vpqcRH+v5Be/9KjVX0TzRSujTn/hD3pW9JgpdTfDG22vTYGH WbtD9ysOOyZEnMD4YBM/ZrMqaeoLAnyaAqcaziimRWjiq7nuCyTE54SQJrlIxPiYaLiOJZ7xUKE dI= X-Received: by 2002:a05:7300:7492:b0:304:188d:d0b0 with SMTP id 5a478bee46e88-30804b8bf3emr75452eec.20.1781128827976; Wed, 10 Jun 2026 15:00:27 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-3074db846f5sm1029212eec.9.2026.06.10.15.00.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2026 15:00:27 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-304ec73b015so3304045eec.1 for ; Wed, 10 Jun 2026 15:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1781128826; x=1781733626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ifrWdwmMtnSLIzspQXoLqNd92UGj3f+HmaYSM1XCOxs=; b=E74d7BnH4WAk762inwWXteWLavIaVX9AVFKgR5VV8AZCb2DXA//DZ1y08TEoaZkeUb gd8B1l1tL0ZhxT51cqyjR+Xfr4egTMD4pfbBhQ/Q9BTXYXsb3GyM/Z2O0e5xjvk5afxn 8RKq4vKgFW07MLI4BToVTDqMdmJGeua1OYU4U= X-Forwarded-Encrypted: i=1; AFNElJ9N7POif1vOFwR0vrCB2a7nnD/ImtSDA093QPn10kk2J3SfPjtmES0UqSt9DLuOUqSXIcsvkO/Q+TGH5TU=@vger.kernel.org X-Received: by 2002:a05:7300:7305:b0:304:c520:4e0c with SMTP id 5a478bee46e88-3080479b610mr95427eec.6.1781128821354; Wed, 10 Jun 2026 15:00:21 -0700 (PDT) X-Received: by 2002:a05:7300:7305:b0:304:c520:4e0c with SMTP id 5a478bee46e88-3080479b610mr95382eec.6.1781128820606; Wed, 10 Jun 2026 15:00:20 -0700 (PDT) Received: from [10.211.247.235] ([192.19.50.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30791f9da69sm19593521eec.31.2026.06.10.15.00.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 15:00:19 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 15:04:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/vmwgfx: Don't use UTS_RELEASE directly To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Zack Rusin , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Markus Schneider-Pargmann , Broadcom internal kernel review list , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260504073422.1130008-2-u.kleine-koenig@baylibre.com> From: Maaz Mombasawala Content-Language: en-US In-Reply-To: <20260504073422.1130008-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/4/26 12:34 AM, Uwe Kleine-König (The Capable Hub) wrote: > UTS_RELEASE evaluates to a static string and changes quite easily (e.g. > uncommitted changes in the source tree or new commits). So when checking > if a patch introduces changes to the resulting binary each usage of > UTS_RELEASE is source of annoyance. > > Instead of using UTS_RELEASE directly use init_utsname()->release which > evaluates to the same string but with that a change of UTS_RELEASE > doesn't affect vmwgfx_drv.o. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- > Hello, > > an alternative way to address this is to drop the kernel version string > completely. But I'm not sure how redundant this really is so I chose the > init_utsname() approach. > > Best regards > Uwe > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 0f101aedb49a..12f5f288ae15 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -24,7 +24,6 @@ > #include > #include > #include > -#include > > #ifdef CONFIG_X86 > #include > @@ -35,6 +34,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1115,7 +1115,7 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id) > vmw_print_sm_type(dev_priv); > vmw_host_printf("vmwgfx: Module Version: %d.%d.%d (kernel: %s)", > VMWGFX_DRIVER_MAJOR, VMWGFX_DRIVER_MINOR, > - VMWGFX_DRIVER_PATCHLEVEL, UTS_RELEASE); > + VMWGFX_DRIVER_PATCHLEVEL, init_utsname()->release); > vmw_write_driver_id(dev_priv); > > dev_priv->pm_nb.notifier_call = vmwgfx_pm_notifier; > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 LGTM! Reviewed-by: Maaz Mombasawala Sorry for missing this patch earlier. Unfortunately our maintainer Zack is out for two weeks so we'll merge this patch at that time. -- Maaz Mombasawala