From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F6F417D6A for ; Wed, 15 Jul 2026 18:39:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784140765; cv=none; b=LN3MgqM7SGWid9e7DrHhiGzmizAC5j8WeSizAlZkrYrPFoVaJz7lYxZFUZ78+Mw8RlFxaWa2NT/HJRgHjXBttpKgqfpg7Y+qCfDIzoQJbTISipYORvuohYSLCTTEIKNvEvqUYrLx45JqLG1KTqEcJtGMd5MmJUb6IU1QBL86HAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784140765; c=relaxed/simple; bh=lrbTnGX7TKcG1lakwP55y1V5gQhQIcXgTURzDGYbL64=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=s6eyKQZVrSggRWQbPqJ6K+XykRhEGO3nu6jCgfPd6ScceaU4LRhODQsRk6/uH4ozAPy96P+nnPWG2hE8ZpXnhAR02kjk2J8N7QYVv2LPaXmgaj6S6jEBOjWT6OiWkoiDb0Nyle4z+4kKdtWdKfY7MDRWLa0eQxjpmNjtbKj8KbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=IG/yhJp1; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="IG/yhJp1" Received: from mail01.layka.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 12DEC8431E; Wed, 15 Jul 2026 20:39:10 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6xLvat8ahXxB; Wed, 15 Jul 2026 20:39:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1784140749; bh=lrbTnGX7TKcG1lakwP55y1V5gQhQIcXgTURzDGYbL64=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=IG/yhJp1X57gm0nKDpVuNPsb2mua2GL3NIiPuFXzLNTpTNjkjvHxotIe1oEuCiHxr U1laKDHppHSIPh+HovfOZ3TY+VbhPWFoOGL/jLE/gdPZbgC6DxDX40RyvKiD6hSz4f tsaZ33g4B2Mckq4HXNHEYrnx8HM7KQKDUF7T2n+fXaGv19gGzSBayGF7+wFMoJy7gc qtToD3yPDWQGMi5VjMlxzMTYBICZWgTwuq8hjzhWpBNuuD86FHok5njApD162+/Zmc myn/dPTpJc1/upRtCXtdsuq26y7WJoy64wN4i+WUPCcqBG2RqRTUL4w8DMbe9WBa+n Gb87CnhgVXDfg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 15 Jul 2026 18:39:09 +0000 From: Rustam Adilov To: Thomas Gleixner Cc: Birger Koblitz , Bert Vermeulen , John Crispin , linux-kernel@vger.kernel.org, Carlo Szelinsky , Markus Stockhausen Subject: Re: [PATCH] irqchip/irq-realtek-rtl: change to __raw reads and writes In-Reply-To: <874ii0pw2z.ffs@fw13> References: <20260711082328.43535-1-adilov@disroot.org> <874ii0pw2z.ffs@fw13> Message-ID: X-Sender: adilov@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2026-07-15 07:10, Thomas Gleixner wrote: > On Sat, Jul 11 2026 at 13:23, Rustam Adilov wrote: > >> To make the interrupt driver operable with SWAP_IO_SPACE >> config enabled, replace all instances of readl/writel with >> their __raw variants. Otherwise readl/writel will do a byte >> swap which this driver does not intend to do. > > Sorry, but this word salad does not qualify as a change log. See > > https://docs.kernel.org/process/maintainer-tip.html#changelog > > First you want to explain what the context: > > When CONFIG_SWAP_IO_SPACE is enabled readl() and writel() imply a byte > swap. > > Then you want to explain why this is not correct for this > driver/hardware. Just saying 'does not intend to do' contains zero > information: > > This is incorrect for the RTL driver, because > > Then you tell how you cure it: > > Fix this by converting the MMIO accesses to __raw_readl() and > __raw_writel(), which do not byte swap the data. Thanks for the review, Honestly my bad for not thinking a bit more on the commit message. That does mean i will have to change commit message in another patch as well as it is a essentially an almost copy of this one... Either way, would this commit message work? When CONFIG_SWAP_IO_SPACE is enabled, readl() and writel() are changed to perform a byte swap to little endian type. This is incorrect because the devices that use the irq-realtek-rtl driver are all big endian MIPS chips. Fix this by converting the MMIO accesses to __raw_readl() and __raw_writel(), which do not byte swap the data. I think just saying "big endian MIPS" should be enough info to tell why byte swapping to "little endian type" (dunno how know else to describe the __le type) is an issue. > Thanks, > > tglx Best, Rustam