From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbeC2HAn (ORCPT ); Thu, 29 Mar 2018 03:00:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45624 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeC2HAl (ORCPT ); Thu, 29 Mar 2018 03:00:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D6689601A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rfried@codeaurora.org Subject: Re: [PATCH] wcn36xx: Disable 5GHz for wcn3610 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , kvalo@codeaurora.org, loic.poulain@linaro.org Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20180329062058.31340-1-rfried@codeaurora.org> <93c900b5-4ddd-bbad-ebe2-4b9549ad8f1c@gmail.com> From: Ramon Fried Message-ID: Date: Thu, 29 Mar 2018 10:00:35 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <93c900b5-4ddd-bbad-ebe2-4b9549ad8f1c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/2018 9:58 AM, Rafał Miłecki wrote: > On 03/29/2018 08:20 AM, Ramon Fried wrote: >> wcn3610 can only operate on 2.4GHz band due to RF limitation. >> If wcn36xx digital block is associated with an external IRIS >> RF module, retrieve the id and disable 5GHz band in case of >> wcn3610 id. >> >> Signed-off-by: Ramon Fried >> --- >>  drivers/net/wireless/ath/wcn36xx/main.c    | 4 +++- >>  drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 + >>  2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c >> index ab5be6d2c691..833531a68c95 100644 >> --- a/drivers/net/wireless/ath/wcn36xx/main.c >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c >> @@ -1146,7 +1146,7 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) >>          BIT(NL80211_IFTYPE_MESH_POINT); >> >>      wcn->hw->wiphy->bands[NL80211_BAND_2GHZ] = &wcn_band_2ghz; >> -    if (wcn->rf_id != RF_IRIS_WCN3620) >> +    if (wcn->rf_id != RF_IRIS_WCN3610 && wcn->rf_id != RF_IRIS_WCN3620) >>          wcn->hw->wiphy->bands[NL80211_BAND_5GHZ] = &wcn_band_5ghz; >> >>      wcn->hw->wiphy->max_scan_ssids = WCN36XX_MAX_SCAN_SSIDS; >> @@ -1248,6 +1248,8 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn, >>      if (iris_node) { >>          if (of_device_is_compatible(iris_node, "qcom,wcn3620")) >>              wcn->rf_id = RF_IRIS_WCN3620; >> +        else if (of_device_is_compatible(iris_node, "qcom,wcn3610")) >> +            wcn->rf_id = RF_IRIS_WCN3620; > > RF_IRIS_WCN3610 ? You're correct. I also noticed just now. Sent v2. Thanks. > > _______________________________________________ > wcn36xx mailing list > wcn36xx@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/wcn36xx