From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A5623F6C5F for ; Tue, 4 Aug 2026 14:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785854032; cv=none; b=HY90SwxD5htlNan/ohRGwXGsrKD5WZgbfOskXohLaiq8BshxJeNbAp7croeCqCks+Lf1SuMFrOP5259cd3gyzb2hRoIf1Q42yCB4r378oVGiW7ggeubQBz3VVX2Xpt3lc8j3HktLea3BXMa0br/Rn0L4FCDkcpVwhqoSy8C6KH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785854032; c=relaxed/simple; bh=4bWofqFbJ9N/pZgeQEpK+3xxRK/uroaVmUtUGmNTRJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FpAhBB29I328NwKVJdpZ1slsAgnuA0syKq56f8s9dmqafcUpwzJIGqfvqAaG7yIewD+5XyZlH430jeLg+tGEJIuwx//lJaM6SfMLQxrdFk3oTqRiBOsnh2k+H8REUnvMcmyUYpFjT/N8AuOHlBBGaJ8b5qpTY9bvIWvVixnmFr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d+GRNG6D; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d+GRNG6D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAB4E1F000E9; Tue, 4 Aug 2026 14:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785854020; bh=z25blQOuYF9jGlFI+RLfaNTy5Rh0Uq97u6eq7NUTIQY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=d+GRNG6DDhHNGtZ8fM9wEv5gaCdrxZmgQgJ68H+PL4UkPJYkWahp2hHeXqj+J0fF0 Tm2WIs4m6X3bfJ+MKgk3lWTwaw8uYTRVwEK+lHcBiXoBkGZalooD3m2acLjeuyC/o2 i5r4c3yYgN9GucSw0HQLvwwRUSmN2oEp6H1EYfdT2p9C6NfKFy9On5TQpdkv5drP3u HfZrsqudqDs/SB8jlE0+LF91YOesfNou8D93lVY0jl+q/w2CdsbgeK0h2IZuLBlnlZ 62bLZRpIS29z2XIKOx2H/US7L1eb+4QDFolYiBjvnzLUzrUemeDpotTfprevLpbEg3 pGcPMHZg9d9Uw== Message-ID: Date: Tue, 4 Aug 2026 16:33:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/page_alloc: only update lowmem_reserve_ratio on sysctl write Content-Language: en-US To: Joel Granados Cc: Andrew Morton , Jianlin Shi , Kees Cook , linux-mm@kvack.org, hannes@cmpxchg.org, surenb@google.com, mhocko@suse.com, jackmanb@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org References: <20260801114434.232c97a74d9616c43aac2456@linux-foundation.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/4/26 14:20, Joel Granados wrote: > On Mon, Aug 03, 2026 at 10:27:46AM +0200, Vlastimil Babka (SUSE) wrote: >> +Cc: sysctl maintainers >> >> On 8/1/26 20:44, Andrew Morton wrote: >> > On Sat, 1 Aug 2026 23:11:25 +0800 Jianlin Shi wrote: >> > >> >> lowmem_reserve_ratio_sysctl_handler() ignores the return value of >> >> proc_dointvec_minmax() and always calls setup_per_zone_lowmem_reserve(), >> >> even for read operations. >> >> >> >> Fix two issues: >> >> >> >> 1. Propagate errors from proc_dointvec_minmax() instead of always >> >> returning success. For example, writing non-integer garbage to the >> >> sysctl now returns an error instead of silently succeeding with >> >> unchanged values. >> > >> > AI review suggest that this caused a new problem: >> > >> > https://sashiko.dev/#/patchset/tencent_1BB7A5C4D5EEA67346634417753190E92A09@qq.com >> > >> > Not sure what to do here. Perhaps pass proc_dointvec_minmax() a >> > temporary then copy that into sysctl_lowmem_reserve_ratio if all >> > proc_dointvec_minmax() returns "OK". >> >> Seeing the v4 [1] it seems easier to keep the current fixup code until >> proc_dointvec_minmax() is fixed. > > 1. V3 -vs- V4: > I would prefer V4 as it actually prevents the partial write of the > vector in case of an error & returns that error back to user space. > Whereas V3 returns the error back to user space but keeps the partial > write. > > That patterns of using a temp ctltable entry is seldom used but not > unheard of. > >> >> > But really this is a flaw in proc_dointvec_minmax() isn't it? It >> > shouldn't update the table data until all the data has been validated. >> >> I agree. What do the maintainers think? > > I agree. The arrays being changed are not too big so we can easily have > a staging variable that that gets written when all validations are done. > The only "con" that I see for this solution is for when these > proc_handlers get used with temp variables; in these cases we will be > staging an already staging variable. Maybe have a variant of the function e.g. proc_dointvec_minmax() that takes an extra parameter pointing to the staging array? That way the caller can allocate it on stack according to its needs (like v4 does) but there's no fiddling with a temp ctltable entry. That way the core code doesn't need a staging variable big enough for everyone, and users can be converted to the new variant, and there's not double staging at any point. > I have added this to my Todos > > Best >