From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71C31D47D9 for ; Mon, 7 Oct 2024 14:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728310484; cv=none; b=f0ygEmMq3jpqr23pz6DxqTwLkVI9g28GreiDTTKvpxsbFTC/Y2eay2RctOhJkUZ1oCihY+1o6RrCNwQ/EJWC+10johI39moCGau+P4W3poR90sM6/CwwvPleHQPV24IjC8IKwHk72RS10Cs7R2kNdycdtrelR5k+Uvx40HQnB7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728310484; c=relaxed/simple; bh=r2ifSG/kqUsvpIDjKytJGBVzY/5Fo40YZqD6xIbDuNM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JA+DdSxm2IkFZ8YXPRTmJqPIs5q6U0WgPBeXNcFeQDk5Y+UExO7QiUJjTP8FdcRwepSb57LN9jWkf48AYHZPvd/nuAjqvqmL7L4Y9874mVY/xAh7cCee2Owkl9jKjsap2f3/pYkB9fBVNh3TM6y2Lu5VjXXp1F/FBZcSu7qp/DM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gcalhgDu; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gcalhgDu" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42cb806623eso41105665e9.2 for ; Mon, 07 Oct 2024 07:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728310481; x=1728915281; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=8LIZjaEwodqIJq0l8LBqKpbQBEU9Mr/e7w5bfiFaSX0=; b=gcalhgDu2fZIqBDtH/SN+YzKUoZiE1xN8vFPD9BiNjjzpcf69c2Kx8SOH+UYZUkI3c yKKgm1Jfh5GJP/QVqWHEBVmmhI5BhySK+LvJaCIX6/6O3dotvyTQxz4kjOrQVj4lTmI1 olUutIKl59M47sgMo/0AS8ZKypatlKi7zZgn6kkfF18QYBsCBNOJznOQwxAH8D7liROB coLk0wFgMYkfgSUDy/UGalWJkM0D2B4+/niMMdSEaBK58Kp2bGYJDYY3n1zqXLP5Y64V /YlAuPlcvcSnUEM8AjuxcwbkdWOUP7VQIY7ByWOxsIZs+2Pf+QtfPIjHXwN+9lfUvRd+ 4lUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728310481; x=1728915281; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LIZjaEwodqIJq0l8LBqKpbQBEU9Mr/e7w5bfiFaSX0=; b=huk6YBGveuI2jWrytPs8so8Np2/Jz6dIZIJrkvUUzWdh7lumkViqfgKFhTPXE8dEka VkYNNtcY5/13uve3XMYJ8JF1JUm2OSF1XG1i0kEOJLMCzjXG2/yeUqKTQddk/sekLZdQ fgRnYgyNbdEFQmszV5l7b9UbVllCLQj4wHZk76jo4KmJlGs2ASsSvvcy9TtjkXkEbZeT KA0ONuEVQ0BlBtH2LCjZzSoBXaVpZym+5fdwlLn8Byz18xM9ZmMIEhhYJwgMaPQs5Y2K dWceKGftN5zOfXWUUqLjp/WChleT4tT+i8zluriOBR2vKmDGdI8inPFEiNf+z09rK0Qz H8FA== X-Forwarded-Encrypted: i=1; AJvYcCWkw8lj9TPCxoPg4/bwIS4dn5JnPieuKWkXPSJjJ1GSLfiWtcKhw7C6QToGzesnycnDA9qT2z0Wzx2ysY0=@vger.kernel.org X-Gm-Message-State: AOJu0YyR8//a4j7265fp2xPEd/UHzxKdBUv3qvDbEBlAbWs+UADqOy9O UPQbwUd1I08XM3GComQ4dHe0JpgCT9qCF5ewPgdeevk2p3JMFnDNh4VqU1Wahnk= X-Google-Smtp-Source: AGHT+IEP2TAhMxAEVDb9cnNXwrxxjf0HxTdnmzszgjiGZHNFxF+3L8SlHfKZdEH74fzu4C9xW9Ze4w== X-Received: by 2002:a05:600c:a01:b0:42c:b995:20ca with SMTP id 5b1f17b1804b1-42f85af43c7mr92506165e9.24.1728310480896; Mon, 07 Oct 2024 07:14:40 -0700 (PDT) Received: from [192.168.2.177] ([207.188.162.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86a2052asm93262705e9.18.2024.10.07.07.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 07:14:39 -0700 (PDT) Message-ID: Date: Mon, 7 Oct 2024 16:14:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: mediatek: pwrap: add pwrap driver for MT8188 SoC To: Macpaul Lin , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alexandre Mergnat Cc: Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , Chris-qj chen , MediaTek Chromebook Upstream , Chen-Yu Tsai References: <20241007024350.7878-1-macpaul.lin@mediatek.com> Content-Language: en-US, ca-ES, es-ES From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRd1TlIARAAm78mTny44Hwd IYNK4ZQH6U5pxcJtU45LLBmSr4DK/7er9chpvJ5pgzCGuI25ceNTEg5FChYcgfNMKqwCAekk V9Iegzi6UK448W1eOp8QeQDS6sHpLSOe8np6/zvmUvhiLokk7tZBhGz+Xs5qQmJPXcag7AMi fuEcf88ZSpChmUB3WflJV2DpxF3sSon5Ew2i53umXLqdRIJEw1Zs2puDJaMqwP3wIyMdrfdI H1ZBBJDIWV/53P52mKtYQ0Khje+/AolpKl96opi6o9VLGeqkpeqrKM2cb1bjo5Zmn4lXl6Nv JRH/ZT68zBtOKUtwhSlOB2bE8IDonQZCOYo2w0opiAgyfpbij8uiI7siBE6bWx2fQpsmi4Jr ZBmhDT6n/uYleGW0DRcZmE2UjeekPWUumN13jaVZuhThV65SnhU05chZT8vU1nATAwirMVeX geZGLwxhscduk3nNb5VSsV95EM/KOtilrH69ZL6Xrnw88f6xaaGPdVyUigBTWc/fcWuw1+nk GJDNqjfSvB7ie114R08Q28aYt8LCJRXYM1WuYloTcIhRSXUohGgHmh7usl469/Ra5CFaMhT3 yCVciuHdZh3u+x+O1sRcOhaFW3BkxKEy+ntxw8J7ZzhgFOgi2HGkOGgM9R03A6ywc0sPwbgk gF7HCLirshP2U/qxWy3C8DkAEQEAAcLBdgQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TlIAhsMAAoJENkUC7JWEwLxtdcP/jHJ9vI8adFi1HQoWUKCQbZdZ5ZJHayFKIzU9kZE /FHzzzMDZYFgcCTs2kmUVyGloStXpZ0WtdCMMB31jBoQe5x9LtICHEip0irNXm80WsyPCEHU 3wx91QkOmDJftm6T8+F3lqhlc3CwJGpoPY7AVlevzXNJfATZR0+Yh9NhON5Ww4AjsZntqQKx E8rrieLRd+he57ZdRKtRRNGKZOS4wetNhodjfnjhr4Z25BAssD5q+x4uaO8ofGxTjOdrSnRh vhzPCgmP7BKRUZA0wNvFxjboIw8rbTiOFGb1Ebrzuqrrr3WFuK4C1YAF4CyXUBL6Z1Lto//i 44ziQUK9diAgfE/8GhXP0JlMwRUBlXNtErJgItR/XAuFwfO6BOI43P19YwEsuyQq+rubW2Wv rWY2Bj2dXDAKUxS4TuLUf2v/b9Rct36ljzbNxeEWt+Yq4IOY6QHnE+w4xVAkfwjT+Vup8sCp +zFJv9fVUpo/bjePOL4PMP1y+PYrp4PmPmRwoklBpy1ep8m8XURv46fGUHUEIsTwPWs2Q87k 7vjYyrcyAOarX2X5pvMQvpAMADGf2Z3wrCsDdG25w2HztweUNd9QEprtJG8GNNzMOD4cQ82T a7eGvPWPeXauWJDLVR9jHtWT9Ot3BQgmApLxACvwvD1a69jaFKov28SPHxUCQ9Y1Y/Ct In-Reply-To: <20241007024350.7878-1-macpaul.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/10/2024 04:43, Macpaul Lin wrote: > MT8188 are highly integrated SoC and use PMIC_MT6359 for > power management. This patch adds pwrap master driver to > access PMIC_MT6359. > > Signed-off-by: Sen Chu > Signed-off-by: Macpaul Lin Reviewed-by: Matthias Brugger > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 33 ++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 9fdc0ef79202..5d3c90e32067 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1087,6 +1087,23 @@ static const int mt8183_regs[] = { > [PWRAP_WACS2_VLDCLR] = 0xC28, > }; > > +static int mt8188_regs[] = { > + [PWRAP_INIT_DONE2] = 0x0, > + [PWRAP_STAUPD_CTRL] = 0x4C, > + [PWRAP_TIMER_EN] = 0x3E4, > + [PWRAP_INT_EN] = 0x420, > + [PWRAP_INT_FLG] = 0x428, > + [PWRAP_INT_CLR] = 0x42C, > + [PWRAP_INT1_EN] = 0x450, > + [PWRAP_INT1_FLG] = 0x458, > + [PWRAP_INT1_CLR] = 0x45C, > + [PWRAP_WACS2_CMD] = 0x880, > + [PWRAP_SWINF_2_WDATA_31_0] = 0x884, > + [PWRAP_SWINF_2_RDATA_31_0] = 0x894, > + [PWRAP_WACS2_VLDCLR] = 0x8A4, > + [PWRAP_WACS2_RDATA] = 0x8A8, > +}; > + > static const int mt8195_regs[] = { > [PWRAP_INIT_DONE2] = 0x0, > [PWRAP_STAUPD_CTRL] = 0x4C, > @@ -1324,6 +1341,7 @@ enum pwrap_type { > PWRAP_MT8173, > PWRAP_MT8183, > PWRAP_MT8186, > + PWRAP_MT8188, > PWRAP_MT8195, > PWRAP_MT8365, > PWRAP_MT8516, > @@ -1845,6 +1863,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) > case PWRAP_MT6797: > case PWRAP_MT8173: > case PWRAP_MT8186: > + case PWRAP_MT8188: > case PWRAP_MT8365: > case PWRAP_MT8516: > pwrap_writel(wrp, 1, PWRAP_CIPHER_EN); > @@ -2393,6 +2412,19 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { > .init_soc_specific = pwrap_mt8183_init_soc_specific, > }; > > +static struct pmic_wrapper_type pwrap_mt8188 = { > + .regs = mt8188_regs, > + .type = PWRAP_MT8188, > + .arb_en_all = 0x777f, > + .int_en_all = 0x180000, > + .int1_en_all = 0, > + .spi_w = PWRAP_MAN_CMD_SPI_WRITE, > + .wdt_src = PWRAP_WDT_SRC_MASK_ALL, > + .caps = PWRAP_CAP_INT1_EN | PWRAP_CAP_ARB, > + .init_reg_clock = pwrap_common_init_reg_clock, > + .init_soc_specific = NULL, > +}; > + > static const struct pmic_wrapper_type pwrap_mt8195 = { > .regs = mt8195_regs, > .type = PWRAP_MT8195, > @@ -2456,6 +2488,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = { > { .compatible = "mediatek,mt8173-pwrap", .data = &pwrap_mt8173 }, > { .compatible = "mediatek,mt8183-pwrap", .data = &pwrap_mt8183 }, > { .compatible = "mediatek,mt8186-pwrap", .data = &pwrap_mt8186 }, > + { .compatible = "mediatek,mt8188-pwrap", .data = &pwrap_mt8188 }, > { .compatible = "mediatek,mt8195-pwrap", .data = &pwrap_mt8195 }, > { .compatible = "mediatek,mt8365-pwrap", .data = &pwrap_mt8365 }, > { .compatible = "mediatek,mt8516-pwrap", .data = &pwrap_mt8516 },