The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: John Garry <john.g.garry@oracle.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <chenxiang66@hisilicon.com>,
	<jinpu.wang@cloud.ionos.com>, <artur.paszkiewicz@intel.com>,
	<dlemoal@kernel.org>, <ipylypiv@google.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE
Date: Tue, 5 Mar 2024 21:47:56 +0800	[thread overview]
Message-ID: <deae273c-7789-e8da-1256-777d01a4ab9f@huawei.com> (raw)
In-Reply-To: <f54e9c30-b483-4dae-9b22-24feb4fc289e@oracle.com>

On 2024/3/5 21:28, John Garry wrote:
> On 05/03/2024 13:19, Jason Yan wrote:
>>> -    .ioctl            = sas_ioctl,
>>> -#ifdef CONFIG_COMPAT
>>> -    .compat_ioctl        = sas_ioctl,
>>> -#endif
>>>       .shost_groups        = mvst_host_groups,
>>>       .sdev_groups        = mvst_sdev_groups,
>>>       .track_queue_depth    = 1,
>>>
>>
>> Doesn't hvae ->eh_abort_handler too.
> 
> Is setting eh_abort_handler actually really ever required for libsas 
> drivers? We have sas_eh_abort_handler, so I assume so..

For now among libsas drivers only isci has eh_abort_handler. But 
LIBSAS_SHT_BASE is setting it by default. I think it's better to keep 
the same as before for other four drivers.

Thanks,
Jason

> 
> Thanks,
> John
> .

  reply	other threads:[~2024-03-05 13:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 12:24 [PATCH 0/6] Add LIBSAS_SHT_BASE for libsas John Garry
2024-03-05 12:24 ` [PATCH 1/6] scsi: libsas: Add LIBSAS_SHT_BASE John Garry
2024-03-05 12:52   ` Jason Yan
2024-03-05 12:24 ` [PATCH 2/6] scsi: pm8001: Use LIBSAS_SHT_BASE John Garry
2024-03-05 12:52   ` Jason Yan
2024-03-05 13:16   ` Jason Yan
2024-03-05 12:24 ` [PATCH 3/6] scsi: hisi_sas: Use LIBSAS_SHT_BASE_NO_SLAVE_INIT John Garry
2024-03-05 12:54   ` Jason Yan
2024-03-05 13:18   ` Jason Yan
2024-03-05 12:24 ` [PATCH 4/6] scsi: aic94xx: Use LIBSAS_SHT_BASE John Garry
2024-03-05 13:09   ` Jason Yan
2024-03-05 12:24 ` [PATCH 5/6] scsi: mvsas: " John Garry
2024-03-05 13:19   ` Jason Yan
2024-03-05 13:28     ` John Garry
2024-03-05 13:47       ` Jason Yan [this message]
2024-03-05 15:26         ` John Garry
2024-03-05 12:24 ` [PATCH 6/6] scsi: isci: " John Garry
2024-03-05 13:21   ` Jason Yan
2024-03-05 13:27     ` John Garry
2024-03-05 13:54       ` Jason Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deae273c-7789-e8da-1256-777d01a4ab9f@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dlemoal@kernel.org \
    --cc=ipylypiv@google.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox