public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dave Taht" <dave.taht@gmail.com>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Breno Leitao" <leitao@debian.org>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Siddharth Vadapalli" <s-vadapalli@ti.com>,
	"Grygorii Strashko" <grygorii.strashko@ti.com>,
	"Dan Carpenter" <dan.carpenter@linaro.org>,
	Netdev <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs
Date: Wed, 28 Feb 2024 15:54:19 +0100	[thread overview]
Message-ID: <debdd4e5-d3f2-4199-a2f7-825e37b212da@app.fastmail.com> (raw)
In-Reply-To: <CAA93jw50D5Kqi4=ze4qn1TUswWtmEao9=FBtH=4W_g9CnBf=AA@mail.gmail.com>

On Wed, Feb 28, 2024, at 15:44, Dave Taht wrote:
> but why do you want to disable BQL?

I have no idea, I'm just doing randconfig build tests.

I assume Breno has an answer for that, at least he
sent the patch that triggered the regression, see below.

     Arnd

commit ea7f3cfaa58873bbe271577efa800647e30f18bd
Author: Breno Leitao <leitao@debian.org>
Date:   Thu Feb 15 09:05:07 2024 -0800

    net: bql: allow the config to be disabled
    
    It is impossible to disable BQL individually today, since there is no
    prompt for the Kconfig entry, so, the BQL is always enabled if SYSFS is
    enabled.
    
    Create a prompt entry for BQL, so, it could be enabled or disabled at
    build time independently of SYSFS.
    
    Signed-off-by: Breno Leitao <leitao@debian.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/Kconfig b/net/Kconfig
index 4adc47d0c9c2..3e57ccf0da27 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -331,6 +331,7 @@ config NET_RX_BUSY_POLL
 
 config BQL
        bool
+       prompt "Enable Byte Queue Limits"
        depends on SYSFS
        select DQL
        default y

  reply	other threads:[~2024-02-28 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 14:03 [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs Arnd Bergmann
2024-02-28 14:44 ` Dave Taht
2024-02-28 14:54   ` Arnd Bergmann [this message]
2024-02-28 14:56 ` Breno Leitao
2024-02-28 15:25 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=debdd4e5-d3f2-4199-a2f7-825e37b212da@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=grygorii.strashko@ti.com \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox