From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f226.google.com (mail-yw1-f226.google.com [209.85.128.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B31D306B0A for ; Fri, 16 Jan 2026 21:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768600174; cv=none; b=DS0x3r09H5RC/9KuyMDiZp8yc4cwWRp0/4gwxS9n7qzaL+px1wIHkiaXMkXS/JMiYiDi19XXC8jKDJa6jV87bzsG0FDKCRBmj26Mu3TYViEBuk9drfxYhzJoB6PfpbodxWaKudZPqFq7o/Xen++00FDUErRZWGaV9zq05Z5p/vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768600174; c=relaxed/simple; bh=+O/kjJ3MdnYKyPkNq52IqDyci8sym5+h+W+0tu6KPlU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pr5kSxX9wzCYcgrThLk+lAzOG6mld/xl3Wi4EOEUuRh5TWzlYOHErdsKOmzaGYqJi1uZZXEtGiB4gFrFxz3P8O+Rf6U5Kq58h1KtOysw1VaL0ZacDwO8CTyVMSzpY97qaKvioU0KKBu9myFEXoDybkVC8dRTh9r6WJovTTvnDn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=E1GEno8q; arc=none smtp.client-ip=209.85.128.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="E1GEno8q" Received: by mail-yw1-f226.google.com with SMTP id 00721157ae682-78fc4425b6bso23707547b3.1 for ; Fri, 16 Jan 2026 13:49:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768600172; x=1769204972; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1vCA+R5fcMfO5sPq0PNAkA7jYgGsq1t74maw1JK+ZqY=; b=rgDPcBKwHBP4ehmgoLuxNo9RumI5kJUb6iwaoNNy87IQiQVttB7yCv0syanLlOoufN OUaJZALhEkPJN6kPphsHCOt6BOpIuUc0ycKG2M6+Zxid0tderjQ974esQTiKwOfh/J4d TC3ZDwp5HwHVd2lkdFuHMEEKPe36zgCYg1lF5mqGCL8ZGBn3CncsacdIAu3a4FVdBz0S tWWK7jgJxtXhQ9YkXvLgfZifbC+OETwB7WQxcgj0L3wwm2Bz4O6EJ96tmcCC6BXU0I0Y xI1aNrPiwfw2OBI9jJSbNk5x80MjsoXNIN3Dpsbbx6KlJRjMaWKkRWe0Dn9fcP4g3oM1 1Sxg== X-Forwarded-Encrypted: i=1; AJvYcCV0zWmYxNvtkLpwiPJzJBaPuUo1sHyLGbnWYb2hwrGK1ozZ451Ebpyu6qOwetUyHHgM3uPQHXWacz0+NgI=@vger.kernel.org X-Gm-Message-State: AOJu0YwBj1JMkqew5AvGaSKpY7/FO2bYToVELh9tesRV71PsZHICXMTL O98jgTPFlFbDwkfCUnXwjuzdo+GHTzJypgnOYs+vukpv/pddtXz8JlLgTR0bypgYuC7TixNOGLU d4OxodQbz9GkUV/9vBGoimkBc0V2i5XzSbn1zx9C+9bT/iVEi+pTILB8FJMXNqUBgcyitHqYgqN GwNQdmTHAOzQUxXeMjsy495+NFmq7Jtq2qu2finS7a0TnEZCFJdXr16nXlaCGjMwJpcYA66gPHw PsTGOKq8lcz+ECPR/wQ+JCZ X-Gm-Gg: AY/fxX5XlKT6aqZt5Ym62EGBHooLbMrNIWutwvvteh8x3ooTyxFtnhBVLYrROsHA2+h zeuKJNZARxl8W9cNx50cNJz/JAi+97TXTHXHaSG67r7nsQF9Uq+8rEOhSfkQCPGnQquYnwPCDrF o/gr4mjXNYZe5PaVWabVKpirr3W8rHfWBOcqn5HjS59AIPN6n5VwneWjvXe2FU/+eQK7hzwF8LV oavM7HXV5pQUOyNfVlu6KYaubVCXSe+QPaqjntBnG1e6utjW2nuQhP/D1/gHN/qFOWQxrHzWvFX rsn+YGQ+U+y92rCxdaeHYgauUeiCuBGvT+cs5fvJe8U72GdpuBhNW7UC6Zts1lpJR5754CvhqNZ MdLjHm5OZpjoQljbfw2nHY6yVOw3SF7RUeo61udEKgAg2gC8u6TH7k2OVY4q8BW7cehkQUKyFXK pWfCG3xMs+8Y+4ILP3spam2zvbtyeI69y8jJv0F7fZ5m1HMaMYAw== X-Received: by 2002:a05:690c:c02:b0:78c:28b7:88e4 with SMTP id 00721157ae682-793c55328a0mr37157757b3.69.1768600172295; Fri, 16 Jan 2026 13:49:32 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-72.dlp.protect.broadcom.com. [144.49.247.72]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-793c8b7d457sm1858007b3.21.2026.01.16.13.49.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2026 13:49:32 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-502a13e3e55so38435771cf.3 for ; Fri, 16 Jan 2026 13:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768600171; x=1769204971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=1vCA+R5fcMfO5sPq0PNAkA7jYgGsq1t74maw1JK+ZqY=; b=E1GEno8q0Q+1qRA3/vA1WPCE8NoI3h5VIbrwpd7tT4GX5Gb0zO5WG9ZEE+0+KBK3iX YH6/iW0n4ZMgkNADP/s/vWRMumU4Nl/AlPg8OMQ8b9hFJJ8tEFbykge2D8P6nYX9/fvV VVYhiHgkR1kScCAxhlaDpsC4aF6wZtF/7oizQ= X-Forwarded-Encrypted: i=1; AJvYcCUbTKbSLinOHd7Gy507v0+ayEL4X4Sw7iAst4mOr/vzAs+ar3B6uI1t/VDSDfS2tg0IeGPKX7mumcAKnUk=@vger.kernel.org X-Received: by 2002:ac8:7dc7:0:b0:501:3d25:18e3 with SMTP id d75a77b69052e-502a1714fc5mr74271171cf.46.1768600171675; Fri, 16 Jan 2026 13:49:31 -0800 (PST) X-Received: by 2002:ac8:7dc7:0:b0:501:3d25:18e3 with SMTP id d75a77b69052e-502a1714fc5mr74270911cf.46.1768600171268; Fri, 16 Jan 2026 13:49:31 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-502a1ed1de6sm29437481cf.17.2026.01.16.13.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jan 2026 13:49:30 -0800 (PST) Message-ID: Date: Fri, 16 Jan 2026 13:49:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/13] ARM: dts: broadcom: bcm2835-rpi: Move non simple-bus nodes to root level To: Rob Herring , Marek Szyprowski Cc: Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Ray Jui , Scott Branden , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260106-dt-dtbs-broadcom-fixes-v1-0-ba45874e4553@kernel.org> <20260106-dt-dtbs-broadcom-fixes-v1-2-ba45874e4553@kernel.org> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/12/26 10:09, Rob Herring wrote: > On Fri, Jan 9, 2026 at 6:01 AM Marek Szyprowski > wrote: >> >> On 07.01.2026 03:09, Rob Herring (Arm) wrote: >>> The 'gpu' and 'firmware' nodes are not MMIO devices, so they should not be >>> under a 'simple-bus'. Additionally, the "raspberrypi,bcm2835-power" node >>> is part of the firmware, so move it under the /firmware node. >>> >>> Signed-off-by: Rob Herring (Arm) >> >> This breaks operation of all drivers under the firmware node. I'm not >> exactly sure why, but they are not properly instantiated. It must be >> something specific to "firmware" name, but I didn't dig enough to find >> exactly where and why. >> >> After changing the "/firmware" node name "xfirmware" everything works again: >> >> >> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi >> b/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi >> index 9ab70b519a63..464f032ccb71 100644 >> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi >> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi >> @@ -1,7 +1,7 @@ >> #include >> >> / { >> - firmware: firmware { >> + firmware: xfirmware { >> compatible = "raspberrypi,bcm2835-firmware", "simple-mfd"; >> mboxes = <&mailbox>; >> >> >> Same issue occurs with bcm2712 change (patch 3/13). > > The issue is how /firmware is handled in drivers/of/platform.c and it > doesn't create a device for the /firmware node. I think the fix here > is /firmware needs to be just a container node and move > "raspberrypi,bcm2835-firmware" down a level. That also allows for > different types of firmware such as a TEE or SCMI should those or > something similar ever be needed. > > I'll see if I can get kernelci to test that change. I don't think my > branch boots all boards though... Dropped this patch for now, until your of_platform.c fix lands and I can apply your two other patches. -- Florian