From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 743393BC68D for ; Mon, 27 Apr 2026 17:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777310972; cv=none; b=TeM2Q8jYejOPGnfwC/w9mplgWjQGap+kqp75Nz5kGLCLWJKCmH5lfS+4yoCJeLIi9twCIfroO5o1Xp/uSPgL/1dcXHk0sAxPhVKe8bLnM6jU/hQxE91w3+ZdhrOES+BWmoLpWDSNRvZXO8sSfCee33DOAQ5v88nIbKHS2ccX69A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777310972; c=relaxed/simple; bh=kRAokQDNXn8lZhiJ7hqV513WEiQtPl40VAaGmz/Tl1o=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: Content-Type:MIME-Version; b=ljYFzqoRgzI1cLRuLnvB5AvbMRzblBnqvxEC6748212ujNdlxMMhLGLVjQCF0MytGSK/z34BY/o/hPEV4WYl0IqbNTPxuP/Yv/q7i2AZtTVeE6TknHI5ZmY1/C8HZUmPZln+1D+qvCXdEIspWQR/+qRCCywRsBiOIUBZ1N+YfTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jsQVoZ29; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jsQVoZ29" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 097DBC19425; Mon, 27 Apr 2026 17:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777310972; bh=kRAokQDNXn8lZhiJ7hqV513WEiQtPl40VAaGmz/Tl1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jsQVoZ29SKcHkIhbwqwieiGkPKQEtH3FGx1gM997a/Hor2BKGN8+Lm4gjmTZcwArJ ZvcN4D9aq0KNVCnD2JzhbXtcVWmHa+7ypxbi2ScEGeobSUXiHnSogu5iBV/HWAMScG 2p49AJhfOMLpSM6zCswt/CoifCpqe6xcOEMDb2QG4bpXYd1yT16mcEGBkfk4sf9v6E Sk7UMyeG15x6v1Uy7iJd/cdwafo/eP+AC5TkvzTBUHcKYwvRsVU/p5Tey8auoMSMPF K3ZGedBk5iu5cNqc3qYeVG5Lgp/ZSS+6BXJWRTgfrYS5QEOhABGrjNuH8Yt/BjVudK LKlYEOU80WPMQ== Date: Mon, 27 Apr 2026 07:29:31 -1000 Message-ID: From: Tejun Heo To: Breno Leitao Cc: Lai Jiangshan , Andy Shevchenko , Krzysztof Kozlowski , clm@fb.com, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] workqueue: fix devm_alloc_workqueue() va_list misuse In-Reply-To: <20260427-wq_fix_chris-v1-1-988649834b79@debian.org> References: <20260427-wq_fix_chris-v1-1-988649834b79@debian.org> Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, Breno. Nice catch. Could you fold both noprof entries onto a shared helper? static struct workqueue_struct * alloc_workqueue_va(const char *fmt, unsigned int flags, int max_active, va_list args) { struct workqueue_struct *wq; wq = __alloc_workqueue(fmt, flags, max_active, args); if (wq) wq_init_lockdep(wq); return wq; } alloc_workqueue_lockdep_map() can stay on bare __alloc_workqueue() since it supplies its own lockdep_map. Thanks. -- tejun