From: Krzysztof Kozlowski <krzk@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: miquel.raynal@bootlin.com, tony@atomide.com, vigneshr@ti.com,
kishon@ti.com, nm@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] memory: omap-gpmc: Allow building as a module
Date: Tue, 29 Mar 2022 10:02:36 +0200 [thread overview]
Message-ID: <def0fe2c-645e-1dbc-8a1a-dd7393176891@kernel.org> (raw)
In-Reply-To: <c9b0b3e5-28f3-67a2-6456-d63f3232e432@kernel.org>
On 29/03/2022 09:37, Roger Quadros wrote:
> Hi Krzysztof,
>
> On 28/03/2022 16:11, Krzysztof Kozlowski wrote:
>> On 28/03/2022 13:13, Roger Quadros wrote:
>>> Allow OMAP_GPMC to be built as a module.
>>>
>>> Remove redundant of_match_node() call before
>>> of_platform_default_populate() as the latter takes
>>> care of matching with of_default_bus_match_table.
>>
>> Split this part to separate commit, please. It does not look related to
>> making it a module.
>
> Actually it is related. Without that change build fails
> as it cannot find symbol 'of_default_bus_match_table'
Hm, because of missing EXPORT?
Then it is related although to me removal of redundant code still could
be split to separate commit. But I do not insist, if you mention it in
commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-29 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:13 [PATCH v2 0/2] memory: omap-gpmc: Allow module build Roger Quadros
2022-03-28 11:13 ` [PATCH v2 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
2022-03-28 11:13 ` [PATCH v2 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros
2022-03-28 13:11 ` Krzysztof Kozlowski
2022-03-29 7:37 ` Roger Quadros
2022-03-29 8:02 ` Krzysztof Kozlowski [this message]
2022-03-29 8:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def0fe2c-645e-1dbc-8a1a-dd7393176891@kernel.org \
--to=krzk@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox