From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF46C433EF for ; Mon, 7 Mar 2022 15:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243989AbiCGQAP (ORCPT ); Mon, 7 Mar 2022 11:00:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234875AbiCGQAM (ORCPT ); Mon, 7 Mar 2022 11:00:12 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132C88118C for ; Mon, 7 Mar 2022 07:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646668758; x=1678204758; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UIQ205em1WrlnAoEopCeQjugklgipYmQxrXTFmaWBqc=; b=htnSgzl3NtHF6CBXLT07Q6v4jrlWThhCt+E8KEs0aaKv1ww2Ao+/4b+4 S0EgnGj/JMHED1TzEWFmRzc2khtlUsMh4vYUbh2sKZis3twHQ4Ex2yjdB 1ZYCjsHyN73WLfLstHSev8lK/2c9SkGhKsSnwbXQgLyGbFG8oArbnp2rV VdfJz//8sknHsRid9M+Od1C914PslmQmMeg5qhFU5gNm1Zr1BEhXsAuLm AhVe6FVy2P82XIRVC3WWwpPcAqZf9HuToZWBT2VyCvabA18NUbjY1CWfs BwY7GC5T+7vW2o5+kvAdTqiQgNLtsx0SWaIIfnbE9CX31hqPDd/yJlksE Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="279128044" X-IronPort-AV: E=Sophos;i="5.90,162,1643702400"; d="scan'208";a="279128044" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 07:59:17 -0800 X-IronPort-AV: E=Sophos;i="5.90,162,1643702400"; d="scan'208";a="643292226" Received: from rhack-mobl1.amr.corp.intel.com (HELO [10.209.14.71]) ([10.209.14.71]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 07:59:17 -0800 Message-ID: Date: Mon, 7 Mar 2022 09:24:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH -next] soundwire: stream: Fix error return code in do_bank_switch() Content-Language: en-US To: Wang Wensheng , vkoul@kernel.org, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: xuqiang36@huawei.com References: <20220307074039.117488-1-wangwensheng4@huawei.com> From: Pierre-Louis Bossart In-Reply-To: <20220307074039.117488-1-wangwensheng4@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/7/22 01:40, Wang Wensheng wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Signed-off-by: Wang Wensheng Thanks for the patch, sounds good to me. Reviewed-by: Pierre-Louis Bossart > --- > drivers/soundwire/stream.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c > index 980f26d49b66..553131597af6 100644 > --- a/drivers/soundwire/stream.c > +++ b/drivers/soundwire/stream.c > @@ -822,6 +822,7 @@ static int do_bank_switch(struct sdw_stream_runtime *stream) > } else if (multi_link) { > dev_err(bus->dev, > "Post bank switch ops not implemented\n"); > + ret = -EINVAL; > goto error; > } >