From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229AbeA3AW5 (ORCPT ); Mon, 29 Jan 2018 19:22:57 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37106 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbeA3AWz (ORCPT ); Mon, 29 Jan 2018 19:22:55 -0500 X-Google-Smtp-Source: AH8x226Xdp8Ekjg5Yg8xiSVcTSnya2K9TlOMLS0pUvi9lo8vRlXuNvLYkb7AA/k9TdE2CQEvQQODYw== Subject: Re: [PATCH 0/2] of: change overlay apply input data from EDT to FDT To: Geert Uytterhoeven Cc: Rob Herring , Pantelis Antoniou , Pantelis Antoniou , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List References: <1517194414-19932-1-git-send-email-frowand.list@gmail.com> From: Frank Rowand Message-ID: Date: Mon, 29 Jan 2018 16:22:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/18 06:08, Geert Uytterhoeven wrote: > Hi Frank, > > On Mon, Jan 29, 2018 at 3:53 AM, wrote: >> From: Frank Rowand >> >> Move duplicating and unflattening of an overlay flattened devicetree >> (FDT) into the overlay application code. To accomplish this, >> of_overlay_apply() is replaced by of_overlay_fdt_apply(). >> >> The copy of the FDT (aka "duplicate FDT") now belongs to devicetree >> code, which is thus responsible for freeing the duplicate FDT. The >> caller of of_overlay_fdt_apply() remains responsible for freeing the >> original FDT. >> >> The unflattened device tree (aka expanded device tree, EDT) now >> belongs to devicetree code, which is thus responsible for freeing >> the EDT. >> >> These ownership changes prevent early freeing of the duplicated FDT >> or the EDT, which could result in use after free errors. >> >> These changes led to migrating some unittest overlay data into >> their own devicetree source files, and then converting most of >> them to use sugar syntax instead of hand coding fragments. > > Thanks for your series! > >> Frank Rowand (2): >> of: change overlay apply input data from EDT to FDT >> of: convert unittest overlay devicetree source to sugar syntax > > Do you plan to update Documentation/devicetree/overlay-notes.txt > and Documentation/devicetree/bindings/fpga/fpga-region.txt, too? Thanks for the pointers. I will add updates to Documentation/devicetree/overlay-notes.txt in this series. The changes to Documentation/devicetree/bindings/fpga/fpga-region.txt are related to the relatively new sugar syntax in dtc, not to the changes introduced by this patch series. I'll create a patch outside this series to update this documentation. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >