From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08FDC3ACF0C for ; Wed, 8 Jul 2026 19:44:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783539847; cv=none; b=B0kxiT4RiwYu5SlqltZBAYzrQS8UptITnXWBhTtEmQWW16DRm/yk7AGWrCZCrLK/+2asgBl1YfkVFZ6VHrHlrFGytqEsYgcr7MG5BOpkBJ7D5CIfbs1XRwCTDvujS/vaxxyP/lokJYDkahs6595zSQxw8joRoaye2TAXRuN5lts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783539847; c=relaxed/simple; bh=sCBV4R2IskE+Qnt8X1ddpdk4fJf5MMWKVa9tRTgLXvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fb5z9OK7X/MFaNVyrNcAljZ+hRrg/4JKiih/AoZvOoLEzJZdVNkKRHN9kRVB260sO7RWGhCH4iICbgbXnafccTpRBGZddZb44lizHdC8zGoH5aezRm/kFGMPeAtM4gu/NhHpJGB4IgTXFJXPTwsE19ODA/luTGgXF/su1UzAUWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9wamYBJ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9wamYBJ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c2c0b9a8so8734155e9.1 for ; Wed, 08 Jul 2026 12:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783539844; x=1784144644; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=sCBV4R2IskE+Qnt8X1ddpdk4fJf5MMWKVa9tRTgLXvA=; b=Z9wamYBJkxQNjZkhmBdNJWvecPMkya3cozZAsa/1bbhEEbfEV+4QvdJj0A+4VqfDOE icvHtxykM+DmHp8EZjo5waUgBHoFU0L6fgUrq4tv3YEIx4rSIXe2PT3xRRhbTs7OjG0Z 03Va/KtNSAOPYTP6gi8YI4g30nerFCmnv8loOh8sIgXNYTmO30Tjw5sJBbJmfuHZEYuq 9qI2tNFmUyBKph+PsKxOplrqbyqhtI/i7WtWQLAlz9qm14MPuDoVHVmZ3aLUc1BCVhZD IvO5KXy9zP7WjvGrw6ZdLevwvr6W+68LFaXW0LZZ/CP/jCUbERmJC/p4K24qfzFk55mq NqpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783539844; x=1784144644; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sCBV4R2IskE+Qnt8X1ddpdk4fJf5MMWKVa9tRTgLXvA=; b=gRR7zxeXa0f8lT4PrVAh5VIujhjF1RxHQT83aJYE1FaeNJs2n9ncwsmoOTkAKPH2YK DSX66/UibQqjRwemKhu2Tf2zV6gIDw+N7qto3bk/4lMABrdml9kghHZvC76PU6YeSXhq GmKjcNqgCfHTA2G2sQ2Wuu/Yc4svBJiYFqYbmd7M/UnR9JIp1QJB60EqlBWMG+QaiMpy tmdTqcpfkRtxjIx1HDWscyVIE0m32Yw5RSjMevx9VQa6T3dFiD7mac3sEJ84dMfon8MP 6NRW7NUzxLiggALXMQ+oJDzLUmeurItWQSHcwDsTG/t65qtOJ9Wz0bg9D1KVcmz0FqMc 3bsg== X-Forwarded-Encrypted: i=1; AHgh+RrdkV5zwPfMM+v7nTuSaAqJvrc9HhN555zvP/U4TI56XrALo2J9kGjz+wbXqkEgYYgK+QUW6Y+IxIeQ21E=@vger.kernel.org X-Gm-Message-State: AOJu0YyB/0mz4pOf6tG5hyL0rET6l1IWPAOvENukBI+kQkuSfVPWf5R4 rcffQWeTx+p/sjX5SEIgc0Bqx/Y/ciAIzsnvWKlq7g+g2Ds3WbRjhrch X-Gm-Gg: AfdE7cn0A0bXee+kaFF2aBKfnt6f85PNNgPCKRsBiveoOTALRO7zmviJvITa64/nINr jH+fkJ4KGMxZCDkH5KqzPkuumXY87nBZ2rnIoCGhT9dInYgLdZKNmH3gTuEhU58Sz5wBP9/SLwo f33yN359DpSlFRuzmEZwELcExjX+G3cOQUNqffxRONKqKRQrclO029z15fLQsMnIBp/N2t6rTum jm63cwdfmHzPdIMrdexQf+lkzn7plzAWNShfQhf3x0bysbQ3DMSDuEPQdINwQkItIFVq+IKRaTG WZbyzsoRDiRNJVuIvEXFV+MknGNyi7mOfLNwvLBwvASLJlbIaGBfkTih7mJyNb5a+JMcm6LDteh /TlxK/ovYX0s0YfQIlKD7P83QN2yrCL/xvJMNN/vmtZdC+7+gYx3ANzEQyvYTBj5IPcTwXfTgfd rHViujHf3HN2x4oIlHH+XlqHHlrP3LKCz1rvPvOjw0FSHYpPZjgnDo1F7WzQ7bxtz6eTw/H11Qw UdmhMaxMUHs X-Received: by 2002:a05:600c:1d0f:b0:493:cfd2:cd06 with SMTP id 5b1f17b1804b1-493e68b8007mr39812645e9.6.1783539844178; Wed, 08 Jul 2026 12:44:04 -0700 (PDT) Received: from ?IPV6:2001:9e8:f108:7101:a0d0:f2a:50b6:7266? ([2001:9e8:f108:7101:a0d0:f2a:50b6:7266]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e3e2702sm47175156f8f.9.2026.07.08.12.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 12:44:03 -0700 (PDT) Message-ID: Date: Wed, 8 Jul 2026 21:44:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/4] dt-bindings: net: pse-pd: add bindings for Realtek/Broadcom PSE MCU Content-Language: en-US To: Conor Dooley Cc: Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Golle , =?UTF-8?Q?Bj=C3=B8rn_Mork?= References: <20260706112425.3149226-1-jelonek.jonas@gmail.com> <20260706112425.3149226-2-jelonek.jonas@gmail.com> <20260706-player-handwash-0a3fe95cf5ec@spud> <20260707-dove-fretful-e3c8e237f1eb@spud> <2afc9c9a-eacc-46ca-b965-4cabee8f7094@gmail.com> <20260708-lyrically-footrest-10963a12145f@spud> From: Jonas Jelonek In-Reply-To: <20260708-lyrically-footrest-10963a12145f@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Conor, On 08.07.26 18:56, Conor Dooley wrote: > On Tue, Jul 07, 2026 at 10:50:21PM +0200, Jonas Jelonek wrote: >> [...] >> Ok, I hope I put this together correctly. A concrete proposal: >> >> "realtek,pse-mcu-gen1"                        (Protocol Gen 1, UART) >> "realtek,pse-mcu-gen1-smbus"            (Protocol Gen 1, SMBus) >> "realtek,pse-mcu-gen2"                        (Protocol Gen 2, UART) >> "realtek,pse-mcu-gen2-i2c"                  (Protocol Gen 2, raw I2C) >> "realtek,pse-mcu-gen2-smbus"            (Protocol Gen 2, SMBus) >> >> This uniquely identifies the protocol used: first generation and second >> generation. As Rob mentioned before [1], this also pulls in the raw I2C >> vs. SMBus framing in contrast to having it in a property. The framing >> suffix appears only on I2C attachments because it doesn't apply to >> UART transport, and this is given by the parent serial@ node. >> >> Though I'm still open for suggestions regarding the protocol >> identification if "-gen1"/"-gen2" is not acceptable. > This seems reasonable enough. > >> [...] >> >> It would also be an exception to the other PSE-PD bindings. They describe >> controllers used across many switches too, yet none encode the > The difference is those cases (for what few pse-psd bindings there are) > the compatibles correspond to individual devices. Here you have > compatibles you're going to use to cover multiple devices (with device > corresponding to a combination of mcu/firmware/hardware behind the mcu). > That lack of a 1:1 mapping is why I'm asking for something different from > you than you see with the existing pse-pd devices. The switch the device > is integrated on seems to be the only thing that reasonably makes sense > to use. > > >> switch/enclosure. Board-specific compatibles might still be added later in >> case a device really has a variation or quirk that genuinely needs its own >> compatible. > And in doing so, have to retrofit that compatible to all devicetrees > that use it. This is one of the reasons that we generally demand > device-specific compatibles. > > You could add switch-specific compatibles that fall back to the ones you > provide above, with the driver only using the ones above unless > something crops up in the future? Thank you for the thorough explanation. I think I got your point now and understand why it's required that way. I'll rework this for the next version. > Cheers, > Conor. Best regards, Jonas