From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65DD121E092 for ; Fri, 20 Dec 2024 17:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734716092; cv=none; b=XtiDiL3pnqf5/cvZuHQ7Ys9pbvwjJyyNOrc+PTq095hHYDQokiZ6X7YNEiaGCrBqerLQ2VQQgbu3hX/ubHwNZwDxNj0zvQIja0UDeXh11FhIMGSwX/5OGYgQw+DlTjvz09sCOfywSrvprsRkm8PAOFozeg8ok/Pkr9iZ1PYLHZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734716092; c=relaxed/simple; bh=sB4Qa9trk67pIn3qtj324FrHhU4l0JkYAxP9D1po14A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iy3ZS7ZK3x8Ydwm2TcQ0QocTXAXWMazdmVc3bLubjz5UnCou7J35VADby+DdAhQ3A49DINw40ZMv9nsu9U53SJtgT2krfOX7Kco868MHRaOfeCnboDaUiH1Ulj0Ni7Az3067yBlrpTrhF1lsG2jAJ10s701+zPhJUyyaMiyku2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QgP/edTA; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QgP/edTA" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-844ee166150so72602839f.2 for ; Fri, 20 Dec 2024 09:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1734716089; x=1735320889; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3bfcorNm0/Wj5y3Z7wXjeJrt/2j0lA2cfaU6IiYz2hU=; b=QgP/edTAI2iPUeMWgdjmt566rpXfMMDIAMFJh+8uz6MQHwtSoax9n8W6Im3a88pLtR iPRjn+ADmlt2wbUUozVgOHlCIF/6kvmqKnDqFwn3Zxb+rqRZbUvigHrCzaBAyY9QPxGT ecDDZ6rsLKJkXT3FqBjPaydKnwfvyKCtfwVW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734716089; x=1735320889; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3bfcorNm0/Wj5y3Z7wXjeJrt/2j0lA2cfaU6IiYz2hU=; b=DFuAZ25AZEkA5YVGTm5VAWZSmJjHwQJrgmNw3jGaGCI3wIxZzOn1gdMOeLCIhCzXBd 2OXncNFXLk7YVfTTvUuQjVJKeRWf00DVaSpZiF6P4d2bokPz0axxER7GOD1nxpCCyexe /AvyhXr+s1bvTEUFzBN2aRSfrqgvg3gXWv9ayZ0obHjfwqhq6pVakPsLOc067QD3wUbC zFkg+YX7hkU0eMLA6pKrAjnMmR9A+1034tGpQSe1mE0Drx884aDTLhKRhNSRNuncAzlz FV+uRGrL8hH6om8S/Rt7kFebL89D7CZWhiIEY5nCbw1Ud+tt9VU7VYOhqDfFMPLXV4i/ kGgw== X-Forwarded-Encrypted: i=1; AJvYcCUVuRhmzojWLish7Jbwl/5WEiPUr9ZKx+OvIQ03ecT1afiio55slCxAPB83dCkMzDc0N5z5G5gDcFmT31M=@vger.kernel.org X-Gm-Message-State: AOJu0YyyALRxomYgz78aQ7Z9dFALVy/Gbr2jH4NqrYcwDuLS18ancTmp UvO95wzDnmQCYkNxst+QsxkHTaQHPaV4s9GLmwQEJX2kJhZVJv6I+rftJRhyCFc= X-Gm-Gg: ASbGncv9H1GL+D0SXAk4rbQv/U/IcKDnnVnhdTUTfd9zQTTjH920WZo6PX6b7htQ+op E05+ld1wU3eMPNMc/7eCsFwLWD+yC75t050jpGVVyjcFKOjk5ZIlRA47frfbyyQzzU/t0wVqMmi ixNnTphCbaFf1WmekSmUAutvz2Sm/lkh3XcLLXD2yn1nGDSyqEVoZGbx4ICaSjvZHecgMENM0HH wD9JQMjJg4y+GHWFlBhRxufiMKfupcWs/85QH0NCz+unyfhTxnU1abektUzAlTVK2Tm X-Google-Smtp-Source: AGHT+IERS0XEXKu0zBuSlavwD3/LW9dk/OiT/DTiE5qVaR8PsSVflTcP0RFBZdkYhG6Y0jZ2zzcTYA== X-Received: by 2002:a05:6602:3c7:b0:841:9d3d:ea14 with SMTP id ca18e2360f4ac-8499e61e2f1mr450577139f.6.1734716089630; Fri, 20 Dec 2024 09:34:49 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e68c1df18bsm874192173.137.2024.12.20.09.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 09:34:49 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 10:34:48 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests To: David Gow , Brian Norris Cc: Greg Kroah-Hartman , Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Shuah Khan References: <20241216201148.535115-1-briannorris@chromium.org> <20241216201148.535115-4-briannorris@chromium.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/18/24 22:45, David Gow wrote: > On Tue, 17 Dec 2024 at 04:12, Brian Norris wrote: >> >> We recently updated these device_match*() (and therefore, various >> *find_device_by*()) functions to return a consistent 'false' value when >> trying to match a NULL handle. Add tests for this. >> >> This provides regression-testing coverage for the sorts of bugs that >> underly commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device >> only if one actually exists"). >> >> Reviewed-by: Maxime Ripard >> Signed-off-by: Brian Norris >> --- >> > > Thanks. This looks good to me. > > Reviewed-by: David Gow > > > This one also can go through Greg's drivers tree: Acked-by: Shuah Khan thanks, -- Shuah