From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 04/10] pmdomain: samsung: plug potential memleak during probe
Date: Fri, 10 Oct 2025 02:35:48 +0200 [thread overview]
Message-ID: <df12e818-5341-4964-9192-71c66d664454@kernel.org> (raw)
In-Reply-To: <20251009-gs101-pd-v2-4-3f4a6db2af39@linaro.org>
On 09/10/2025 00:25, André Draszik wrote:
> of_genpd_add_provider_simple() could fail, in which case this code
> leaks the domain name, pd->pd.name.
>
> Use devm_kstrdup_const() to plug this leak. As a side-effect, we can
> simplify existing error handling.
>
> Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver")
> Cc: stable@vger.kernel.org
> Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-10 0:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 15:25 [PATCH v2 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-09 15:25 ` [PATCH v2 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-10 18:31 ` Rob Herring (Arm)
2025-10-09 15:25 ` [PATCH v2 02/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2025-10-10 12:23 ` Rob Herring (Arm)
2025-10-10 14:16 ` André Draszik
2025-10-10 14:09 ` Rob Herring
2025-10-09 15:25 ` [PATCH v2 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children André Draszik
2025-10-10 5:26 ` André Draszik
2025-10-10 14:13 ` Rob Herring
2025-10-09 15:25 ` [PATCH v2 04/10] pmdomain: samsung: plug potential memleak during probe André Draszik
2025-10-10 0:35 ` Krzysztof Kozlowski [this message]
2025-10-09 15:25 ` [PATCH v2 05/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-09 15:25 ` [PATCH v2 06/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-09 15:25 ` [PATCH v2 07/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-09 15:25 ` [PATCH v2 08/10] pmdomain: samsung: selectively handle enforced sync_state André Draszik
2025-10-09 15:25 ` [PATCH v2 09/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-09 15:25 ` [PATCH v2 10/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df12e818-5341-4964-9192-71c66d664454@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox