public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zizhi Wo <wozizhi@huawei.com>
To: David Howells <dhowells@redhat.com>
Cc: <netfs@lists.linux.dev>, <jlayton@kernel.org>,
	<hsiangkao@linux.alibaba.com>, <jefflexu@linux.alibaba.com>,
	<zhujia.zj@bytedance.com>, <linux-erofs@lists.ozlabs.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<libaokun1@huawei.com>, <yangerkun@huawei.com>,
	<houtao1@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH 6/8] cachefiles: Modify inappropriate error return value in cachefiles_daemon_secctx()
Date: Thu, 10 Oct 2024 19:47:29 +0800	[thread overview]
Message-ID: <df196eaa-e017-4f2e-a443-0431873a5d71@huawei.com> (raw)
In-Reply-To: <304108.1728559896@warthog.procyon.org.uk>



在 2024/10/10 19:31, David Howells 写道:
> Zizhi Wo <wozizhi@huawei.com> wrote:
> 
>> In cachefiles_daemon_secctx(), if it is detected that secctx has been
>> written to the cache, the error code returned is -EINVAL, which is
>> inappropriate and does not distinguish the situation well.
> 
> I disagree: it is an invalid parameter, not an already extant file, and a
> message is logged for clarification.  I'd prefer to avoid filesystem errors as
> we are also doing filesystem operations.
> 
> David
> 
> 

Alright, what I originally intended was to differentiate the error codes
between cases where no arguments are specified and where cache->secctx
already exists.

Thanks,
Zizhi Wo

  reply	other threads:[~2024-10-10 11:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  2:42 [PATCH 0/8] netfs/cachefiles: Some bugfixes Zizhi Wo
2024-08-21  2:42 ` [PATCH 1/8] cachefiles: Fix incorrect block calculations in __cachefiles_prepare_write() Zizhi Wo
2024-10-10 10:34   ` David Howells
2024-10-10 11:11     ` Zizhi Wo
2024-10-10 11:36       ` David Howells
2024-10-10 12:17         ` Zizhi Wo
2024-10-10 13:15         ` Zizhi Wo
2024-08-21  2:42 ` [PATCH 2/8] cachefiles: Fix incorrect length return value in cachefiles_ondemand_fd_write_iter() Zizhi Wo
2024-08-21  2:42 ` [PATCH 3/8] cachefiles: Fix missing pos updates " Zizhi Wo
2024-10-10 11:26   ` David Howells
2024-08-21  2:42 ` [PATCH 4/8] cachefiles: Clear invalid cache data in advance Zizhi Wo
2024-10-10 11:16   ` David Howells
2024-08-21  2:42 ` [PATCH 5/8] cachefiles: Clean up in cachefiles_commit_tmpfile() Zizhi Wo
2024-10-10 11:23   ` David Howells
2024-08-21  2:42 ` [PATCH 6/8] cachefiles: Modify inappropriate error return value in cachefiles_daemon_secctx() Zizhi Wo
2024-10-10 11:31   ` David Howells
2024-10-10 11:47     ` Zizhi Wo [this message]
2024-08-21  2:43 ` [PATCH 7/8] cachefiles: Fix NULL pointer dereference in object->file Zizhi Wo
2024-10-10 11:26   ` David Howells
2024-10-10 12:04     ` Zizhi Wo
2024-10-10 14:52       ` David Howells
2024-10-11  1:31         ` Zizhi Wo
2024-08-21  2:43 ` [PATCH 8/8] netfs/fscache: Add a memory barrier for FSCACHE_VOLUME_CREATING Zizhi Wo
2024-10-10 11:24   ` David Howells
2024-10-10  3:08 ` [PATCH 0/8] netfs/cachefiles: Some bugfixes Zizhi Wo
2024-10-10  3:31   ` Gao Xiang
2024-10-10  4:08     ` Zizhi Wo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df196eaa-e017-4f2e-a443-0431873a5d71@huawei.com \
    --to=wozizhi@huawei.com \
    --cc=dhowells@redhat.com \
    --cc=houtao1@huawei.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=jlayton@kernel.org \
    --cc=libaokun1@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=yangerkun@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhujia.zj@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox