From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8A3227B87 for ; Fri, 20 Dec 2024 19:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734724598; cv=none; b=LrBvfogI1kYW+J4IMUSTj+4yCYY4M6Es20FQGGK7FW6L1cVxIQQw81gzOm6wt8K6DRJDUVCWDrbPxMWtSYZwnBBYLy10VpkElbw8nVaUXOV4yQ0pVoHw40bfN5TUrI+j3kA/KItbHa21Jjb+lHxHzMzcj8qzhUKPFwR9//tpzis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734724598; c=relaxed/simple; bh=xIFZ+Qn3bT9RlpOfJFPG92bjFLVmgTecZy2LyxCmRVs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPpzDY0x5f4zhK7CisrQUmMAGmKQiFeuM6ipThyVmovDKwow3hsB/aSGIY881m6OZwmdPlSkmRnitW3YVPxXg46uS6rnFNUwZtQo29bw05hM/A/qNMvXF3CW+sPaJTkvcRaH/5rTdEzbRcNRYFXedJNr2u/yRbkipJeC37uzKtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ztzmoup6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ztzmoup6" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKDHbTA018142 for ; Fri, 20 Dec 2024 19:56:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CNXi4HVvLwEnmfialNLMEUNaS0/KanL2j5mXVBCUz9w=; b=Ztzmoup6WnqTqnor ZvTDquigCZfl6PsIl8o3iovgSU5l7uML8oTAwRdOyJIb19Qlfri4RWhBWWYp5NXC ueOW43cV6jMTdDL22Ui3vDelmCgnIV/tezNcrFrNOwscRKkTO1+E6lXeiKX8DiKn qmIvE9aVpMjWWdhIT3buxPVTpfm1mTQo5W2uwGWhggCwU/OXEPT0SymWT23ESUYo BzeHj6p5vwbPYI5gTWgyV/F46xJSvKcQdB4rCvNOJzDqsutJxXuozK8lLRA8rLKr 0RlzEJ666DNkpFKSBxdtCjNOLZfPvsiaDQGK1s3GQwZQreORLPhUkXDMKoP2YAf8 5/lbkA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43n9b9h237-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 20 Dec 2024 19:56:36 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d8f8762a69so3836216d6.3 for ; Fri, 20 Dec 2024 11:56:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734724595; x=1735329395; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CNXi4HVvLwEnmfialNLMEUNaS0/KanL2j5mXVBCUz9w=; b=JcXK6BDRu34efPTqKNR5VnRrGVPUwsUQKceh1tctwolWIGKdi0ZqXtQ7MAaCVna7oW xPekgG0EjX0e28xXPfWhTX+V/3y1dAm26Tzuuw49kjRpokT+7O6b/YTJSTpCMl6VxQ6N W3b5oG87EqUl69Yf29VRBIhGGmIXspBMKTOee6w5qV+X+BUMB18lCfB+U7YFTsqkpRRj W/Hu9VYerlz/X2gzZFr5iiMxQmzd53ALuL2NsB54qV8aSwMJIKaefTNNQgdCZR3p4hPm ygLip3ykcEXdGhjCabhw8X0GgVqxZrYxdB6tI3psDL4+WEdiJEuaO9wwUfYqz7zoipNc /sBw== X-Forwarded-Encrypted: i=1; AJvYcCWE2z7e1iJz1R1GWYyDK63NBVItHp6HMsbZ3yi5LRyDSPRLMpHzikdl3K8Izo6G/J3/I1WUeShyO5v+vlE=@vger.kernel.org X-Gm-Message-State: AOJu0Yztl5bgKSjC1C+tvS9YmQDGo/7TUYiMXjzqarnl44A5EKRif9wR Omu0Txpuw7R0Uzju7Mj3r54D6HLn4on7RAc3PIYlGnbKoIK5ufZ/QwVKQHp8+TRB89R9YevWypA 5uAn2RqZdnJRr2lYo5CIQlKtzRz6+wCU0YGxGc11XkeM6BJzGtYrVng3BA9MofY8= X-Gm-Gg: ASbGncvPLID2QvcrmeGYw/W6gUtzuUIByMANcwbVho7DQdzCio4i61ma7q8F88ZZspT 3Zc4ava1ZBBhJ4vhaT1OK0C2w+qL/BKZJocB+NIulFnpi3WLRFEVnC+rRuZuolDezLoTxLjD1pB +sIqLtCYaAgzemGEUXzVSl3Nqf3l7K19iH2U9wXp1/Zlt1FpQ1sjmoXYemDI2pbX0+LdOAvYK07 3vv4doDiaGhdqeRuAikOhAOG9PgMLmgLKYIvvjdb3RBQ0D1qY+e/hD6lREQnNlUDnVSMd7KDg04 vr3yQXXqOWxaR9IvFiQtBA9yAcqwRucsWas= X-Received: by 2002:ad4:5de1:0:b0:6d8:e634:203a with SMTP id 6a1803df08f44-6dd23327990mr24024416d6.4.1734724594931; Fri, 20 Dec 2024 11:56:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6O7L0eT7hcle0d+mEEQSfXKZLRu3gm/NoMZrAmdKcF5OuBOOm4hLGodWNUXrXW8QaaUU7+g== X-Received: by 2002:ad4:5de1:0:b0:6d8:e634:203a with SMTP id 6a1803df08f44-6dd23327990mr24024226d6.4.1734724594596; Fri, 20 Dec 2024 11:56:34 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe4653sm210771066b.122.2024.12.20.11.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 11:56:34 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 20:56:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm/msm/a6xx: Add support for Adreno 612 To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jie Zhang , Konrad Dybcio References: <20241213-a612-gpu-support-v3-1-0e9b25570a69@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241213-a612-gpu-support-v3-1-0e9b25570a69@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: _q-XWvx9toGuxOyXqZUayTAQYb97TwZC X-Proofpoint-GUID: _q-XWvx9toGuxOyXqZUayTAQYb97TwZC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412200160 On 13.12.2024 12:46 PM, Akhil P Oommen wrote: > From: Jie Zhang > > Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. > A612 falls under ADRENO_6XX_GEN1 family and is a cut down version > of A615 GPU. > > A612 has a new IP called Reduced Graphics Management Unit or RGMU > which is a small state machine which helps to toggle GX GDSC > (connected to CX rail) to implement IFPC feature. It doesn't support > any other features of a full fledged GMU like clock control, resource > voting to rpmh etc. So we need linux clock driver support like other > gmu-wrapper implementations to control gpu core clock and gpu GX gdsc. > Since there is no benefit with enabling RGMU at the moment, RGMU is > entirely skipped in this patch. > > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > Reviewed-by: Konrad Dybcio > --- So we talked offline a bit, and the RGMU requires a piece of firmware. We concluded it's best to describe that from the get-go, so that the user doesn't get surprised when a new kernel update brings new firmware requirements for previously-working hardware. Please wait for the new revision. Konrad