From: Bryan O'Donoghue <bod@kernel.org>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Stephan Gerhold" <stephan@gerhold.net>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/9] remoteproc: qcom_q6v5_mss: Introduce need_pas_mem_setup
Date: Thu, 1 Jan 2026 13:17:11 +0000 [thread overview]
Message-ID: <df31119d-5c22-431e-a7f2-4ac1203de564@kernel.org> (raw)
In-Reply-To: <20251231-mss-v3-1-f80e8fade9ec@mainlining.org>
On 31/12/2025 16:30, Barnabás Czémán wrote:
> Some platforms like MSM8953 and MSM8937 TZ needs to be
> informed of the modem start address and pas_id.
> Lets introduce need_pas_mem_setup flag for handle this case.
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 91940977ca89..3c404118b322 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -162,6 +162,7 @@ struct rproc_hexagon_res {
> char **proxy_pd_names;
> int version;
> bool need_mem_protection;
> + bool need_pas_mem_setup;
> bool has_alt_reset;
> bool has_mba_logs;
> bool has_spare_reg;
> @@ -240,6 +241,7 @@ struct q6v5 {
> struct qcom_sysmon *sysmon;
> struct platform_device *bam_dmux;
> bool need_mem_protection;
> + bool need_pas_mem_setup;
> bool has_alt_reset;
> bool has_mba_logs;
> bool has_spare_reg;
> @@ -1441,7 +1443,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> max_addr = ALIGN(phdr->p_paddr + phdr->p_memsz, SZ_4K);
> }
>
> - if (qproc->version == MSS_MSM8953) {
> + if (qproc->need_pas_mem_setup) {
> ret = qcom_scm_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size);
> if (ret) {
> dev_err(qproc->dev,
> @@ -2224,6 +2226,7 @@ static const struct rproc_hexagon_res sc7180_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = true,
> .has_spare_reg = true,
> @@ -2253,6 +2256,7 @@ static const struct rproc_hexagon_res sc7280_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = true,
> .has_spare_reg = false,
> @@ -2285,6 +2289,7 @@ static const struct rproc_hexagon_res sdm660_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2321,6 +2326,7 @@ static const struct rproc_hexagon_res sdm845_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = true,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2353,6 +2359,7 @@ static const struct rproc_hexagon_res msm8998_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2392,6 +2399,7 @@ static const struct rproc_hexagon_res msm8996_mss = {
> NULL
> },
> .need_mem_protection = true,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2427,6 +2435,7 @@ static const struct rproc_hexagon_res msm8909_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2473,6 +2482,7 @@ static const struct rproc_hexagon_res msm8916_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2509,6 +2519,7 @@ static const struct rproc_hexagon_res msm8953_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = true,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2562,6 +2573,7 @@ static const struct rproc_hexagon_res msm8974_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2600,6 +2612,7 @@ static const struct rproc_hexagon_res msm8226_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
> @@ -2646,6 +2659,7 @@ static const struct rproc_hexagon_res msm8926_mss = {
> NULL
> },
> .need_mem_protection = false,
> + .need_pas_mem_setup = false,
> .has_alt_reset = false,
> .has_mba_logs = false,
> .has_spare_reg = false,
>
> --
> 2.52.0
>
>
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
next prev parent reply other threads:[~2026-01-01 13:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 16:30 [PATCH v3 0/9] MDM9607/MSM8917/MSM8937/MSM8940 MSS Barnabás Czémán
2025-12-31 16:30 ` [PATCH v3 1/9] remoteproc: qcom_q6v5_mss: Introduce need_pas_mem_setup Barnabás Czémán
2026-01-01 13:17 ` Bryan O'Donoghue [this message]
2025-12-31 16:30 ` [PATCH v3 2/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MDM9607 Barnabás Czémán
2026-01-02 10:58 ` Krzysztof Kozlowski
2025-12-31 16:30 ` [PATCH v3 3/9] remoteproc: qcom_q6v5_mss: " Barnabás Czémán
2026-01-01 13:13 ` Bryan O'Donoghue
2026-01-01 13:19 ` Bryan O'Donoghue
2026-01-01 13:23 ` Bryan O'Donoghue
2026-01-01 13:50 ` barnabas.czeman
2026-01-01 20:58 ` Bryan O'Donoghue
2026-01-01 21:57 ` barnabas.czeman
2026-01-02 9:55 ` Bryan O'Donoghue
2026-01-02 12:50 ` barnabas.czeman
2026-01-02 12:00 ` Konrad Dybcio
2026-01-02 12:59 ` Bryan O'Donoghue
2026-01-02 14:02 ` Konrad Dybcio
2026-01-02 13:00 ` Bryan O'Donoghue
2026-01-02 14:03 ` Konrad Dybcio
2026-01-03 7:41 ` barnabas.czeman
2025-12-31 16:30 ` [PATCH v3 4/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8917 Barnabás Czémán
2026-01-02 10:59 ` Krzysztof Kozlowski
2025-12-31 16:30 ` [PATCH v3 5/9] remoteproc: qcom_q6v5_mss: " Barnabás Czémán
2025-12-31 16:30 ` [PATCH v3 6/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8937 Barnabás Czémán
2026-01-02 11:00 ` Krzysztof Kozlowski
2025-12-31 16:30 ` [PATCH v3 7/9] remoteproc: qcom_q6v5_mss: " Barnabás Czémán
2025-12-31 16:30 ` [PATCH v3 8/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8940 Barnabás Czémán
2026-01-02 11:00 ` Krzysztof Kozlowski
2025-12-31 16:30 ` [PATCH v3 9/9] remoteproc: qcom_q6v5_mss: " Barnabás Czémán
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df31119d-5c22-431e-a7f2-4ac1203de564@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox