From: Takis <panagiotis.issaris@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] drivers/media: Conversions from kmalloc+memset to kzalloc.
Date: Thu, 5 Jan 2006 13:39:43 +0100 [thread overview]
Message-ID: <df33fe7c0601050439o7d2ae3b3k@mail.gmail.com> (raw)
In-Reply-To: <84144f020601050423j19b73446l143162a9ef6067b@mail.gmail.com>
Hi,
2006/1/5, Pekka Enberg <penberg@cs.helsinki.fi>:
> On 1/5/06, Panagiotis Issaris <takis@issaris.org> wrote:
> > 993e5ce2979baa3df3d8dd238d74ea3b607e4693
> > diff --git a/drivers/media/common/saa7146_core.c b/drivers/media/common/saa7146_core.c
> > index 2899d34..38982a7 100644
> > --- a/drivers/media/common/saa7146_core.c
> > +++ b/drivers/media/common/saa7146_core.c
> > @@ -109,10 +109,9 @@ static struct scatterlist* vmalloc_to_sg
> > struct page *pg;
> > int i;
> >
> > - sglist = kmalloc(sizeof(struct scatterlist)*nr_pages, GFP_KERNEL);
> > + sglist = kzalloc(sizeof(struct scatterlist)*nr_pages, GFP_KERNEL);
>
> Hmm, these should be converted to kcalloc().
Oops... you're right. I'll send an updated patch later this evening.
With friendly regards,
Takis
prev parent reply other threads:[~2006-01-05 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 10:43 [PATCH] drivers/media: Conversions from kmalloc+memset to kzalloc Panagiotis Issaris
2006-01-05 12:23 ` Pekka Enberg
2006-01-05 12:39 ` Takis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df33fe7c0601050439o7d2ae3b3k@mail.gmail.com \
--to=panagiotis.issaris@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=takis@issaris.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox