From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH] checkpatch: add support for title acrosses three lines in commit id description
Date: Sun, 3 May 2020 15:03:45 +0200 [thread overview]
Message-ID: <df619612-3825-4637-e025-618a7a982310@web.de> (raw)
In-Reply-To: <20200503123435.GD10332@udknight>
> The current GIT_COMMIT_ID will report error when the title in commit id
> description acrosses three lines, …
I suggest to improve the commit message (and subsequent Perl code)
also according to the usage of the text “acrosses”.
> This patch adds support for three lines title in the commit id description,
> and emit diagnostics info when the title acrosses more than three lines.
Please split this paragraph into two imperative wordings.
Regards,
Markus
next prev parent reply other threads:[~2020-05-03 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 12:34 [PATCH] checkpatch: add support for title acrosses three lines in commit id description Wang YanQing
2020-05-03 13:03 ` Markus Elfring [this message]
2020-05-03 15:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df619612-3825-4637-e025-618a7a982310@web.de \
--to=markus.elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox