From: David Ahern <dsahern@kernel.org>
To: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>,
davem@davemloft.net, jiri@resnulli.us, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] selftests:net change ifconfig with ip command
Date: Mon, 23 Oct 2023 08:18:57 -0600 [thread overview]
Message-ID: <df63abf1-90cc-4f94-90e4-0ffb44c914f2@kernel.org> (raw)
In-Reply-To: <20231023123422.2895-1-swarupkotikalapudi@gmail.com>
On 10/23/23 6:34 AM, Swarup Laxman Kotiaklapudi wrote:
> Change ifconfig with ip command,
> on a system where ifconfig is
> not used this script will not
> work correcly.
>
> Test result with this patchset:
>
> sudo make TARGETS="net" kselftest
> ....
> TAP version 13
> 1..1
> timeout set to 1500
> selftests: net: route_localnet.sh
> run arp_announce test
> net.ipv4.conf.veth0.route_localnet = 1
> net.ipv4.conf.veth1.route_localnet = 1
> net.ipv4.conf.veth0.arp_announce = 2
> net.ipv4.conf.veth1.arp_announce = 2
> PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
> bytes of data.
> 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.038 ms
> 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.068 ms
>
> --- 127.25.3.14 ping statistics ---
> 5 packets transmitted, 5 received, 0% packet loss, time 4073ms
> rtt min/avg/max/mdev = 0.038/0.062/0.068/0.012 ms
> ok
> run arp_ignore test
> net.ipv4.conf.veth0.route_localnet = 1
> net.ipv4.conf.veth1.route_localnet = 1
> net.ipv4.conf.veth0.arp_ignore = 3
> net.ipv4.conf.veth1.arp_ignore = 3
> PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
> bytes of data.
> 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.032 ms
> 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.065 ms
> 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.066 ms
> 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.065 ms
> 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.065 ms
>
> --- 127.25.3.14 ping statistics ---
> 5 packets transmitted, 5 received, 0% packet loss, time 4092ms
> rtt min/avg/max/mdev = 0.032/0.058/0.066/0.013 ms
> ok
> ok 1 selftests: net: route_localnet.sh
> ...
>
> Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> ---
> tools/testing/selftests/net/route_localnet.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
> index 116bfeab72fa..e08701c750e3 100755
> --- a/tools/testing/selftests/net/route_localnet.sh
> +++ b/tools/testing/selftests/net/route_localnet.sh
> @@ -18,8 +18,10 @@ setup() {
> ip route del 127.0.0.0/8 dev lo table local
> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
>
> - ifconfig veth0 127.25.3.4/24 up
> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
> + ip address add 127.25.3.4/24 dev veth0
> + ip link set dev veth0 up
> + ip netns exec "${PEER_NS}" ip address add 127.25.3.14/24 dev veth1
> + ip netns exec "${PEER_NS}" ip link set dev veth1 up
>
> ip route flush cache
> ip netns exec "${PEER_NS}" ip route flush cache
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-10-23 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 11:31 [PATCH] selftests:net change ifconfig with ip command Swarup Laxman Kotiaklapudi
2023-10-22 17:50 ` David Ahern
2023-10-23 7:12 ` Jiri Pirko
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-23 14:18 ` David Ahern [this message]
2023-10-24 21:00 ` patchwork-bot+netdevbpf
2023-10-23 14:19 ` [PATCH] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df63abf1-90cc-4f94-90e4-0ffb44c914f2@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox