From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbdHGOlo (ORCPT ); Mon, 7 Aug 2017 10:41:44 -0400 Received: from mout.web.de ([212.227.15.14]:57053 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbdHGOlm (ORCPT ); Mon, 7 Aug 2017 10:41:42 -0400 To: "David S. Miller" , Jens Axboe , "Liam R. Howlett" , kernel-janitors@vger.kernel.org Cc: LKML From: SF Markus Elfring Subject: [PATCH] sunvdc: Delete an error message for a failed memory allocation in vdc_port_probe() Message-ID: Date: Mon, 7 Aug 2017 16:41:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:usbIXxkn3MWeQfYlwnyeGfi2DESXPvmCEpMn81FfVsg8Eoo8die WJqcCDgNQCLSRz81JsVF9YizeCPRgOgsDpqZ0v5wb+HZ5FNqgPTgHeNxWEKrvNoMVyXjy30 UDBO2k7eloHueoiDTTWThJWfgbfMD4HqmCWnt5AHD4B7jxTPWuXhySFyNscSZBa+tmStz1X iTUx2h1/CX8rnvbM8h/Sw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HyZYwRRL5lo=:GqyK1VHu3WY4gSyETIBtli wX4kQtqfWWmdGu0vyRq+C95dVmYRgdWdnOMF51scVtdp/nL8uQS1wRkJ1QWtw98ReHl04sAL3 qT+XFowfWofLsDQWlww2tsDvGn2coU59/7D/ANEvcmXz9rbsRnE8AX6IBS6kf1aLY3JwGPpyl WL88dASH8sXZOTU3iILf+SeznxeMlYNclhi1XJPrbJbOR2hs25QOvHwKvpt8LhThDTNm98X3y hpfI6LHVg41FsYKin37gZ9uDV+S3R0Iuuoqk7I3KpsBjH+SPzWz+ZgrvA4EPj0fPKt+RrWAN/ pjRqzzufQsmDG/QPZ7TaPk9ttnqfTQHszjVsdAsM2vaDWzbCDVaNbumDWTubvjemmZ4C8LhsZ g7hFTkSBMuZi/+b3QgAycSXBK3+gCnGZVrd1XMkuJu7bZyaFs2jJIv5ELXWHEjGccOiV4f1pJ wqY0dFax3FQmnnSt4VvFE0lvWnrJ7Ijo611KpVzM3iqRX3gWYjyjbW+Ml00z8ucMAZgGawMCh YZ6A/RJR2JCOxjT1gyWtA8L4W88hLgUP6sTcfEOVqFXDlpDt/H1TQsOrZdRIuX21czrs8csTH ouzDAWmV/dGEsuOnh8rn4SGAHtLaepj1NFm9yeqI8tIPIoucpEz5U6KrmF/SkBZZMWALgT6iD 3nz5s03qTBJYnLkKqQA9qLytyukCj2MfjuTq3k9DYxRWhUZFwGry0NUHilE3n72i8d8xMnpPq OuQ/7NjTDGBMDw9kqBu9nIMVK/szezh+ajFRW4dtq2MVW3UMpMkXljkv95NGYR0PIgMxkcrRF /Vi7VlzMTIzjEJ/6rLAsclaoQjquewD7AT9whjJ4G6fGf7Es0U= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 7 Aug 2017 16:28:54 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/block/sunvdc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index 6b16ead1da58..34f8619d6597 100644 --- a/drivers/block/sunvdc.c +++ b/drivers/block/sunvdc.c @@ -894,9 +894,8 @@ static int vdc_port_probe(struct vio_dev *vdev, const struct vio_device_id *id) } port = kzalloc(sizeof(*port), GFP_KERNEL); - err = -ENOMEM; if (!port) { - printk(KERN_ERR PFX "Cannot allocate vdc_port.\n"); + err = -ENOMEM; goto err_out_release_mdesc; } -- 2.13.4