From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4333A33FE2A for ; Tue, 3 Feb 2026 12:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121536; cv=none; b=TmiJ6dmGMI/vD6CvFPHM5OGQ6FFa/E9cLh2ixpMO5FoujNUpk+Hv2XP8vzvAA8TNqnpk2Eq2ITbWH+nFo2gukyquR4BHh9RC/XLTQnvMGTgq3jQ9eiHalhS9VtrGJHbU/kyUWkaJj8osHo79xm18GsqLmHKUyj0KVS4QtqY0qEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121536; c=relaxed/simple; bh=q0BC+UNwqgkm+AoQaAiSVdLDeuvHClDj7duIXglk7RU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dfZzHt79ecJ+FybnsA8JWUuqoZhB6JV1CeKSI97FSqyIe33g/VROIUAgifuhMjzzz/KIDrN2yea3fDKIg1WxKVPKeFkKbxy0iNizw1GbZj4/8eccEfSmk9MVocBF5asPadVLA1EnLcaMGw7MrZ58wd47E50gdjWfLQQd5f3phsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VGj0sV16; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q00qQlC/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VGj0sV16"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q00qQlC/" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613BlMNG2418285 for ; Tue, 3 Feb 2026 12:25:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kr9VkLymfmxS+ULRZoGX6sAx4XQrg7pGqU67+DmAAfI=; b=VGj0sV16COHQZLLJ bTb4nKpwOXw3jgTPBBQws41x/U6s3Y4GHDkTWd4XCppUqUa7kEzcLhPlFUxIC3tG 0ja51DKluhhIqSGzXkEVPX5huOXPMKcIMFtosy62cKcN5RFX7HWYJzNfd8iZn60t +wXJg5qTXs6Tnrr9ef0R1u+BXA+ZYWwuvLLDtYiQbwfbb8ZCEkrc1wh9lrSHXVo7 /YBj8OJmGetGdV2Bv/rT4uPuf2uSIUD+bgp5Bag05yntFq2Ry7nzDYZuIr9WuNeJ yGU4FRLlh1eBqYyDtTvU9rIL0OyymN2VGXkmiRurFaxpvXEwJMvgdXWUz616/occ Y75BoQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3gew83ev-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 12:25:34 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c533f07450so143590285a.0 for ; Tue, 03 Feb 2026 04:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770121533; x=1770726333; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kr9VkLymfmxS+ULRZoGX6sAx4XQrg7pGqU67+DmAAfI=; b=Q00qQlC/6pzHN2a6IuqWeRInUzVhEz6/PE71B6LD1ndLLglFaTeA1RMiairbeWCsJs 5CEYZm4WWLye1BTR7L1Zubo44zPB40Q26/Q3Gh6KLYex7U7tdODkncgjmndn01kEQCdL XBKDwA26zjZOi2xPmXXlSM03kWIGHGzYOSbA8U2natxY/mmkGBA1yNWaTYfOrpJ5al2i PyCXx/Na70S3RDuG1in3Vp83cMOKOoeZ8F8xm1WJmKardkSJx8w963ciFm0O7qU+h3X7 gjSYQ82bz41ypvNrYiGha9pc74V4XBzB8pTdOc81ad4Ob55hi8EHCYoR5JZVPzodPq7w fpRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770121533; x=1770726333; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kr9VkLymfmxS+ULRZoGX6sAx4XQrg7pGqU67+DmAAfI=; b=SmVVpWX9nDjLXyjNGpbqw13Ga0Q1TQH6HuMKs4Fe3ucSQkTfaYnTFAug8awrpFcuAI LJBep/rXV1qDWorevmmDpBT8BPXLyJCGJaHP12jyr3nsl1yEWz6edz7AA4YCEUknKnSi 7YhyPF5HEVXn7P+4pQsDKb8lYKRxXPuOZJCMTx24l0NM9FwyGS9fRexJLSfex3aDoN+o CWYUE20lhN0MMxqeCilkAhR7nZwVBN719yv8L6c8FB5YZkk8gvKzOn3+1RdZ0zhZUclQ UeDdccZxVg6ZIXEZMU4YK9v23z4ngcVIkZXHLMoL22uqrLlh/FWLadmrN5XlEPAdVvwF /cwg== X-Forwarded-Encrypted: i=1; AJvYcCVJhUNxbASdQbXPxgeMgCCesr/+jEokMSjY8n+uBg70YXZqHgQuNTZ6I26GiCEdNOlyB/qvCJ5+WaPyXAw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6DN6AHx9r44AaA89QqemnNs05Rt2O1LtOtMNQPdbtvVihx1Mr qxSOll3ZlXB/8KN7MXvNJrm86Gcx5419nFYVtCCW+YUyfbZZ78c9ZraEbItigRa8OKe5qkp3i6S +RZwNr1g7hWZJQxlWndRf8nRR5qwm4hW6EqdkRE756lk7tGcBrnxPrheJxmu20VtL+2Y= X-Gm-Gg: AZuq6aKHYqMXQFdp5F1c9OLiCb21QMFH+YxgJoZJWJhtYFhXKfKrlaZqngXOB2LUeIY BUJD7yvXmnqqpJ0ivXJ/5zFkkTWyX1WHt9xJIX9ncB9Ufa7jO3QvGy8+RWJilO69FMvKA9Eps0s jFPBjFRGW73WAMglbZ1hMjX39ok9Tc9vlRb96devD1QfwTwaQeqdxvgdckj7rjJxgxZ2o+cR+8B KCfKOGtOhm9xppXVHK31GfHP1349Az4ObIqixwI+V/eep4FjsBKBLIXb/oYSKNBlRL/Dxk+pQqx eQjWRmFtj76dVTN12S2EyCMrGM6dYRbRY+ETg0uxDIEMzv1YUZ3E7Du3FdS61m9J3RMk0YUJzs0 M4DA8uvirai0lbHw13bROIQbjb5j3AiGIKp/AyAAZVGbwlpZ1YOXQKxjEoBdAXtwL9vo= X-Received: by 2002:a05:620a:454b:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8c9eb285634mr1499523085a.3.1770121533581; Tue, 03 Feb 2026 04:25:33 -0800 (PST) X-Received: by 2002:a05:620a:454b:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8c9eb285634mr1499520585a.3.1770121533149; Tue, 03 Feb 2026 04:25:33 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbeffedd3sm1003274366b.29.2026.02.03.04.25.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 04:25:32 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 13:25:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-13-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202180922.1692428-13-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ng3fsVFGu9iA2_qC_YEksPTcHA4ofT_Q X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5OCBTYWx0ZWRfXyXh7m+q7ykuQ tBSb+CQWLfQ/Ij3czYNClkJ48RpXpMpUIZduRzBK4m2ZcOt/YBnmIdZJPsjQWwkaJ76lsnLNy1B /aZ0cxNMY8ktQTODqnC8JH3zMJXdVe4K0KDid5PG8ZqS/Z9BpGB0EtnvkxaxHBIpQXLi5FNgkI8 g2EI39ARq0gMeSy3Vg+E+1fCPKNey13TYHM53ae9Um5cBvvHlBVGmLZqOPnHX+A4xFO+g4cJXnW VQ9rui+k+wowASCW6VxtTyENNBJXfCAHchwzkJWS8PfQmd3zSHcmQjKsxSdcuWQx+iZO73vaEml zmkYsqxhkkliSQcUvc3X2gURNi4rXXR1c2vWylUXF6gAveOUWucDH1lIcN7uP1vfrrNBxArR/vF AObcy32ZD16k8VfM+Dp8F0jt564qbkVZkB7SvohLTwA6HnDkIH5Zrx4VBErfRtsv77MfVKMb+Cw sivrZZQUvhLz+xDmytA== X-Authority-Analysis: v=2.4 cv=XI89iAhE c=1 sm=1 tr=0 ts=6981e93e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LkbPghAf8A_mGgTKem4A:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=zZCYzV9kfG8A:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: ng3fsVFGu9iA2_qC_YEksPTcHA4ofT_Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_04,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030098 On 2/2/26 7:09 PM, Praveen Talari wrote: > To avoid repeatedly fetching and checking platform data across various > functions, store the struct of_device_id data directly in the i2c > private structure. This change enhances code maintainability and reduces > redundancy. > > Acked-by: Viken Dadhaniya > Signed-off-by: Praveen Talari > --- [...] > > - desc = device_get_match_data(&pdev->dev); > + gi2c->dev_data = device_get_match_data(&pdev->dev); Because you dereference it unconditionally later, this should be null-checked Konrad