From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: bmi160: Fix ODR setting
Date: Wed, 4 May 2016 10:51:03 +0100 [thread overview]
Message-ID: <df9ec160-714b-72b7-cd9a-67bdd3092c89@kernel.org> (raw)
In-Reply-To: <1461930155-13871-3-git-send-email-daniel.baluta@intel.com>
On 29/04/16 12:42, Daniel Baluta wrote:
> mask and val parameters of regmap_update_bits were reveresed.
>
> Fixes: 77c4ad2d6a9 ("iio: imu: Add initial support for Bosch BMI160")
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git.
Not pushed out as anything at all yet.
Jonathan
> ---
> drivers/iio/imu/bmi160/bmi160_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> index cd9b75e..b8a290e 100644
> --- a/drivers/iio/imu/bmi160/bmi160_core.c
> +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> @@ -364,8 +364,8 @@ int bmi160_set_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>
> return regmap_update_bits(data->regmap,
> bmi160_regs[t].config,
> - bmi160_odr_table[t].tbl[i].bits,
> - bmi160_regs[t].config_odr_mask);
> + bmi160_regs[t].config_odr_mask,
> + bmi160_odr_table[t].tbl[i].bits);
> }
>
> static int bmi160_get_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>
next prev parent reply other threads:[~2016-05-04 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 11:42 [PATCH 0/3] Add available sampling frequency and scale attributes Daniel Baluta
2016-04-29 11:42 ` [PATCH 1/3] iio: bmi160: Fix output data rate for accel Daniel Baluta
2016-05-01 19:00 ` Jonathan Cameron
2016-05-04 9:50 ` Jonathan Cameron
2016-04-29 11:42 ` [PATCH 2/3] iio: bmi160: Fix ODR setting Daniel Baluta
2016-05-04 9:51 ` Jonathan Cameron [this message]
2016-04-29 11:42 ` [PATCH 3/3] imu: bmi160: Add avail frequency and scale attributes Daniel Baluta
2016-05-01 19:01 ` Jonathan Cameron
2016-05-04 9:51 ` Jonathan Cameron
2016-05-01 18:57 ` [PATCH 0/3] Add available sampling " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9ec160-714b-72b7-cd9a-67bdd3092c89@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox