From: Dave Hansen <dave.hansen@intel.com>
To: Haitao Huang <haitao.huang@linux.intel.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
linux-sgx@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: kai.huang@intel.com, reinette.chatre@intel.com,
kristen@linux.intel.com, seanjc@google.com,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: fix a NULL pointer
Date: Tue, 18 Jul 2023 07:27:49 -0700 [thread overview]
Message-ID: <dfb1f233-aebd-50cf-8704-e83b91ee110a@intel.com> (raw)
In-Reply-To: <20230717202938.94989-1-haitao.huang@linux.intel.com>
On 7/17/23 13:29, Haitao Huang wrote:
> Under heavy load, the SGX EPC reclaimers (current ksgxd or future EPC
> cgroup worker) may reclaim the SECS EPC page for an enclave and set
> encl->secs.epc_page to NULL. But the SECS EPC page is used for EAUG in
> the SGX #PF handler without checking for NULL and reloading.
>
> Fix this by checking if SECS is loaded before EAUG and load it if it was
> reclaimed.
It would be nice to see a _bit_ more theory of the bug in here.
What is an SECS page and why is it special in a reclaim context? Why is
this so hard to hit? What led you to discover this issue now? What is
EAUG?
next prev parent reply other threads:[~2023-07-18 14:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:17 [PATCH] x86/sgx: fix a NULL pointer Haitao Huang
2023-07-17 18:53 ` Jarkko Sakkinen
2023-07-17 18:54 ` Jarkko Sakkinen
2023-07-17 20:29 ` Haitao Huang
2023-07-17 22:42 ` Huang, Kai
2023-07-18 0:45 ` Haitao Huang
2023-07-18 1:39 ` Huang, Kai
2023-07-18 2:42 ` Haitao Huang
2023-07-18 14:27 ` Dave Hansen [this message]
2023-07-18 18:11 ` Haitao Huang
2023-07-18 18:53 ` Dave Hansen
2023-07-18 20:32 ` Haitao Huang
2023-07-18 20:56 ` Dave Hansen
2023-07-18 21:22 ` Haitao Huang
2023-07-18 21:36 ` Dave Hansen
2023-07-18 21:57 ` Haitao Huang
2023-07-18 22:05 ` Dave Hansen
2023-07-19 0:06 ` Haitao Huang
2023-07-19 0:14 ` Huang, Kai
2023-07-19 0:21 ` Dave Hansen
2023-07-19 13:53 ` Haitao Huang
2023-07-21 0:32 ` Huang, Kai
2023-07-21 0:52 ` Huang, Kai
2023-07-26 16:56 ` Haitao Huang
2023-07-18 14:30 ` Dave Hansen
2023-07-18 16:39 ` Haitao Huang
2023-07-18 15:37 ` Jarkko Sakkinen
2023-07-18 23:11 ` Haitao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb1f233-aebd-50cf-8704-e83b91ee110a@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox