From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>,
Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
linux-hwmon@vger.kernel.org, "Guenter Roeck" <linux@roeck-us.net>,
"Jean Delvare" <jdelvare@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Delphine CC Chiu" <Delphine_CC_Chiu@wiwynn.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Radu Sabau" <radu.sabau@analog.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Alexis Czezar Torreno" <alexisczezar.torreno@analog.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800
Date: Wed, 20 Nov 2024 18:35:33 +0100 [thread overview]
Message-ID: <dfe8e47e-6c31-4b11-b733-38e5bd0e49d3@kernel.org> (raw)
In-Reply-To: <20241120-process-hulk-ecedcbf088f7@spud>
On 20/11/2024 18:11, Conor Dooley wrote:
> On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote:
>> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus.
>> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
>> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
>> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
>>
>> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
>> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
>> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
>
> Why did you drop my ack?
> https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/
So that's a v2? Or v3? Then should be marked correctly. Please start
using b4. I already asked analog.com for this in few cases. Feel free
not to use b4 if you send correct patches, but this is not the case here.
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-20 17:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 3:58 [PATCH 0/2] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Cedric Encarnacion
2024-11-20 3:58 ` [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800 Cedric Encarnacion
2024-11-20 17:11 ` Conor Dooley
2024-11-20 17:35 ` Krzysztof Kozlowski [this message]
2024-11-20 18:07 ` Guenter Roeck
2024-11-20 18:39 ` Krzysztof Kozlowski
2024-11-25 2:44 ` Encarnacion, Cedric justine
2024-11-29 9:12 ` Nuno Sá
2024-11-20 18:00 ` Guenter Roeck
2024-11-23 19:56 ` Conor Dooley
2024-11-23 19:58 ` Conor Dooley
2024-11-25 2:44 ` Encarnacion, Cedric justine
2024-11-25 18:48 ` Conor Dooley
2024-11-20 3:58 ` [PATCH 2/2] hwmon: (pmbus/adp1050): add support " Cedric Encarnacion
2024-11-20 5:00 ` Randy Dunlap
2024-11-20 13:45 ` Andy Shevchenko
2024-11-20 13:52 ` Andy Shevchenko
2024-11-20 14:53 ` Guenter Roeck
2024-11-20 16:29 ` Andy Shevchenko
2024-11-25 3:07 ` Encarnacion, Cedric justine
2024-11-20 14:39 ` Guenter Roeck
2024-11-21 21:54 ` kernel test robot
2024-11-22 13:46 ` kernel test robot
2024-11-23 3:11 ` kernel test robot
2024-11-27 0:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe8e47e-6c31-4b11-b733-38e5bd0e49d3@kernel.org \
--to=krzk@kernel.org \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=alexisczezar.torreno@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cedricjustine.encarnacion@analog.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox