From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbcGSFgT (ORCPT ); Tue, 19 Jul 2016 01:36:19 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57854 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbcGSFgP (ORCPT ); Tue, 19 Jul 2016 01:36:15 -0400 Subject: Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting To: Laxman Dewangan , Alison Schofield References: <20160716022831.GA7636@d830.WORKGROUP> <578C9843.10408@nvidia.com> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfram Sang , Linux I2C From: Jonathan Cameron Message-ID: Date: Mon, 18 Jul 2016 14:30:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <578C9843.10408@nvidia.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/16 09:50, Laxman Dewangan wrote: > > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >> auto-detection. IIO drivers don't typically use .class. >> Remove it. >> >> Signed-off-by: Alison Schofield >> Cc: Daniel Baluta >> > > Agree. > Acked-by: Laxman Dewangan Any resulting ABI change from dropping it? I don't think so, as it doesn't support detection anyway, but best to be sure ;) > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html