public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joao Moreira <joao@overdrivepizza.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	x86@kernel.org, Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] x86/ibt: Implement FineIBT
Date: Mon, 24 Oct 2022 11:38:16 -0700	[thread overview]
Message-ID: <dffbc3cc5babe4f7ed2e5d41edad7dec@overdrivepizza.com> (raw)
In-Reply-To: <CABCJKuc8eu0t08E0e1si-Sm2m0QqB1mrzofZy9cJ3G-tHBUZRg@mail.gmail.com>

> Yes, the compiler patch is already in, but if the cfi/kcfi confusion
> is a big concern, it's still possible to rename the symbol before
> Clang 16 is released. However, I thought we picked the __cfi prefix
> earlier to make things less confusing with FineIBT? Joao, are you
> still planning on adding FineIBT to Clang as well?

Not only with FineIBT, but also with CFG, ClangCFI and any other scheme 
that does CFI. IIRC, my concern was regarding some functions/structures 
that could be easily re-used in both (or many) schemes (such as setting 
the hashes for a specific call or something) being named to one 
specifically. But yeah, I didn't think at the time that there would be a 
different collision with Dwarf stuff. I still think that having a 
generic prefix is better, but I agree that the collision with dwarf is 
bad. Maybe we use something generic enough that doesn't collide, Idk, 
"cflow" or something like that (naming is hard).

As for FineIBT within clang, that is still undecided. I'm waiting for 
peterz's patches to get in first, so then I can raise the discussion if 
it is worthy compiling the kernel directly with FineIBT. Also, on the 
user-space side, I'm waiting for IBT support to get in to then get back 
there and see if I can make it feasible. So the answer right now is 
really that it depends.

Tks,
Joao

      reply	other threads:[~2022-10-24 20:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 13:35 [PATCH] x86/ibt: Implement FineIBT Peter Zijlstra
2022-10-18 14:43 ` David Laight
2022-10-18 15:58   ` Joao Moreira
2022-10-18 17:20     ` Kees Cook
2022-10-18 20:09       ` Joao Moreira
2022-10-19  5:33         ` Kees Cook
2022-10-18 21:27     ` David Laight
2022-10-18 14:47 ` Peter Zijlstra
2022-10-18 18:09 ` Kees Cook
2022-10-18 19:56   ` Peter Zijlstra
2022-10-18 23:31     ` Josh Poimboeuf
2022-10-19  5:22       ` Kees Cook
2022-10-19 11:38       ` Peter Zijlstra
2022-10-19  5:14     ` Kees Cook
2022-10-18 19:59   ` Peter Zijlstra
2022-10-18 21:09     ` Peter Zijlstra
2022-10-19  5:05     ` Kees Cook
2022-10-19 12:03       ` Peter Zijlstra
2022-10-19 15:22         ` Sami Tolvanen
2022-10-20 11:04           ` Peter Zijlstra
2022-10-18 19:59   ` Joao Moreira
2022-10-19  5:32     ` Kees Cook
2022-10-19 19:35       ` Joao Moreira
2022-10-18 20:05   ` Peter Zijlstra
2022-10-19  5:00     ` Kees Cook
2022-10-18 20:09   ` Peter Zijlstra
2022-10-18 20:17     ` Joao Moreira
2022-10-18 20:30       ` Peter Zijlstra
2022-10-19  4:48         ` Joao Moreira
2022-10-19  5:19           ` Kees Cook
2022-10-31 19:13             ` Joao Moreira
2022-11-01 21:39               ` Kees Cook
2022-11-01 21:50                 ` Joao Moreira
2024-05-06 17:36                   ` Kees Cook
2024-05-07  1:45                     ` Joao Moreira
2022-10-19  5:18         ` Kees Cook
2022-10-19  5:16     ` Kees Cook
2022-10-20 11:05   ` Peter Zijlstra
2022-10-18 23:38 ` Josh Poimboeuf
2022-10-19  7:29   ` Peter Zijlstra
2022-10-21 23:08 ` Josh Poimboeuf
2022-10-22 15:03   ` Peter Zijlstra
2022-10-24 17:15     ` Sami Tolvanen
2022-10-24 18:38       ` Joao Moreira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dffbc3cc5babe4f7ed2e5d41edad7dec@overdrivepizza.com \
    --to=joao@overdrivepizza.com \
    --cc=jpoimboe@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=samitolvanen@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox