public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Seigh <jseigh_02@xemaps.com>
To: linux-kernel@vger.kernel.org
Subject: Re: Notifier chains are unsafe
Date: Sat, 29 Oct 2005 08:25:04 -0400	[thread overview]
Message-ID: <djvpme$p83$1@sea.gmane.org> (raw)
In-Reply-To: <E1EUxn7-00081k-00@gondolin.me.apana.org.au>

Herbert Xu wrote:
> Andreas Kleen <ak@suse.de> wrote:
> 
>>Am Mi 26.10.2005 02:01 schrieb Chandra Seetharaman
>><sekharan@us.ibm.com>:
>>
>>
>>>>Better would be likely to use RCU.
>>>
>>>RCU will be a problem if the registered notifiers need to block.
>>
>>?
>>Actually blocking should be ok, as long as the blocking notifier doesn't
>>unregister
>>itself. The current next pointer will be always reloaded after the
>>blocking.
> 
> 
> Blocking would be OK as long as you reference count the objects.


With or without RCU?  I.e., it's just a straighforward reference counting
solution and RCU is being used to allow incrementing the reference counts
safely.  Otherwise, without RCU you'd need a lock to safely increment the
reference counts.  Also note that with reference counting, the deletes of
the objects can occur any time a reference count is decremented.  So that
would include the notify_call threads as well.

--
Joe Seigh


  reply	other threads:[~2005-10-29 12:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24 20:48 Notifier chains are unsafe Alan Stern
2005-10-25 16:59 ` Joe Seigh
2005-10-25 23:30 ` Chandra Seetharaman
2005-10-26 18:46   ` Alan Stern
2005-10-26 19:05     ` Andreas Kleen
2005-10-26 20:40       ` Alan Stern
2005-10-26 21:44         ` Andi Kleen
2005-10-26 23:20           ` Chandra Seetharaman
2005-10-27  1:17             ` Joe Seigh
2005-10-28  1:36               ` Chandra Seetharaman
2005-10-27 14:13           ` Alan Stern
2005-10-26 22:40     ` Chandra Seetharaman
2005-10-27 15:28       ` Alan Stern
2005-10-27 20:43         ` Chandra Seetharaman
2005-10-27 21:21           ` Alan Stern
2005-10-27 23:02             ` Chandra Seetharaman
2005-10-28  0:48               ` Keith Owens
2005-10-28  1:34                 ` Chandra Seetharaman
2005-10-28 14:23                   ` Alan Stern
2005-10-28 22:15                     ` Chandra Seetharaman
2005-10-29 14:51                       ` Alan Stern
2005-10-31 22:22                         ` Chandra Seetharaman
2005-11-01 15:24                           ` Alan Stern
2005-11-01 20:20                             ` Chandra Seetharaman
2005-11-01 21:20                               ` Alan Stern
2005-11-02  9:50                                 ` Keith Owens
2005-11-02 16:03                                   ` Alan Stern
     [not found]               ` <mailman.1130460600.30060.linux-kernel2news@redhat.com>
2005-10-28  4:35                 ` Pete Zaitcev
2005-10-25 23:43 ` Andi Kleen
2005-10-26  0:01   ` Chandra Seetharaman
2005-10-26 17:11     ` Andreas Kleen
2005-10-27  2:46       ` Herbert Xu
2005-10-29 12:25         ` Joe Seigh [this message]
2005-10-26  6:11 ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='djvpme$p83$1@sea.gmane.org' \
    --to=jseigh_02@xemaps.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox