* [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86.
@ 2012-01-11 19:16 Grant Likely
2012-01-12 9:22 ` Milton Miller
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2012-01-11 19:16 UTC (permalink / raw)
To: linux-kernel; +Cc: Grant Likely, Denis Turischev
This driver does an unconditional read of io space during module init which
causes a bad dereference on ARM. It looks to me like this is an x86 only
drivers, so restrict it to only compile on x86.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Denis Turischev <denis@compulab.co.il>
---
drivers/gpio/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 37c4bd1..76146b5 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,6 +87,7 @@ config GPIO_GENERIC_PLATFORM
config GPIO_IT8761E
tristate "IT8761E GPIO support"
+ depends on X86
help
Say yes here to support GPIO functionality of IT8761E super I/O chip.
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86.
2012-01-11 19:16 [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86 Grant Likely
@ 2012-01-12 9:22 ` Milton Miller
2012-01-12 14:56 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Milton Miller @ 2012-01-12 9:22 UTC (permalink / raw)
To: Grant Likely; +Cc: Denis Turischev, linux-kernel
On Wed Jan 11 2012 - 14:16:36 EST, Grant Likely wrote:
> This driver does an unconditional read of io space during module init which
> causes a bad dereference on ARM. It looks to me like this is an x86 only
> drivers, so restrict it to only compile on x86.
> config GPIO_IT8761E
> tristate "IT8761E GPIO support"
> + depends on X86
> help
> Say yes here to support GPIO functionality of IT8761E super I/O chip.
Please add a comment to the Kconfig stanza with the reason for the
dependancy so people don't have to be git blame masters to know why
its there.
Something like
depends on X86 # unconditional read of io space during module init
thanks,
milton
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86.
2012-01-12 9:22 ` Milton Miller
@ 2012-01-12 14:56 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-01-12 14:56 UTC (permalink / raw)
To: Milton Miller; +Cc: Denis Turischev, linux-kernel
On Thu, Jan 12, 2012 at 2:22 AM, Milton Miller <miltonm@bga.com> wrote:
> On Wed Jan 11 2012 - 14:16:36 EST, Grant Likely wrote:
>> This driver does an unconditional read of io space during module init which
>> causes a bad dereference on ARM. It looks to me like this is an x86 only
>> drivers, so restrict it to only compile on x86.
>
>> config GPIO_IT8761E
>> tristate "IT8761E GPIO support"
>> + depends on X86
>> help
>> Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
>
> Please add a comment to the Kconfig stanza with the reason for the
> dependancy so people don't have to be git blame masters to know why
> its there.
>
> Something like
> depends on X86 # unconditional read of io space during module init
okay, will do.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-12 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 19:16 [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86 Grant Likely
2012-01-12 9:22 ` Milton Miller
2012-01-12 14:56 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox