From: Sohil Mehta <sohil.mehta@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
"Huang, Kai" <kai.huang@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"xin@zytor.com" <xin@zytor.com>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH 5/9] x86/nmi: Fix comment in unknown NMI handling
Date: Mon, 31 Mar 2025 22:53:04 -0700 [thread overview]
Message-ID: <e01c2866-87d2-4881-9825-1b033dead5de@intel.com> (raw)
In-Reply-To: <BF35DF73-974C-4C8F-8ECE-3C9C254BAD1C@zytor.com>
On 3/31/2025 10:45 PM, H. Peter Anvin wrote:
> Ha! Any idea what it was *supposed* to do? I'm guessing it stood for "back to back" or some such?
Yes, it stands for back to back NMIs. I added additional comments to
clarify how they are detected.
https://lore.kernel.org/lkml/20250327234629.3953536-7-sohil.mehta@intel.com/
nmi_handle() still has special handling for back to back NMIs. But at
some point, there was a b2b parameter that was passed to nmi_handle().
AFAICT, that parameter was never really used.
Sohil
next prev parent reply other threads:[~2025-04-01 5:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 23:46 [PATCH 0/9] x86: Cleanup NMI handling Sohil Mehta
2025-03-27 23:46 ` [PATCH 1/9] x86/nmi: Simplify unknown NMI panic handling Sohil Mehta
2025-03-31 22:52 ` Huang, Kai
2025-03-31 23:01 ` Sohil Mehta
2025-04-01 15:00 ` Nikolay Borisov
2025-04-01 15:54 ` Sohil Mehta
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 2/9] x86/nmi: Consolidate NMI panic variables Sohil Mehta
2025-03-31 22:43 ` Huang, Kai
2025-03-31 22:50 ` Sohil Mehta
2025-03-31 23:05 ` Huang, Kai
2025-03-31 23:20 ` Sohil Mehta
2025-04-01 1:06 ` Huang, Kai
2025-04-01 5:46 ` Sohil Mehta
2025-04-01 8:08 ` Huang, Kai
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 3/9] x86/nmi: Use a macro to initialize NMI descriptors Sohil Mehta
2025-03-31 23:46 ` Huang, Kai
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 4/9] x86/nmi: Remove export of local_touch_nmi() Sohil Mehta
2025-03-31 23:47 ` Huang, Kai
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 5/9] x86/nmi: Fix comment in unknown NMI handling Sohil Mehta
2025-04-01 0:17 ` Huang, Kai
2025-04-01 5:28 ` Sohil Mehta
2025-04-01 5:45 ` H. Peter Anvin
2025-04-01 5:53 ` Sohil Mehta [this message]
2025-04-03 13:33 ` [tip: x86/nmi] x86/nmi: Fix comment in unknown_nmi_error() tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 6/9] x86/nmi: Improve and relocate NMI handler comments Sohil Mehta
2025-04-01 1:03 ` Huang, Kai
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 7/9] x86/nmi: Improve NMI header documentation Sohil Mehta
2025-03-31 10:47 ` Ingo Molnar
2025-03-31 16:04 ` Sohil Mehta
2025-03-31 21:36 ` Sohil Mehta
2025-04-01 8:08 ` Ingo Molnar
2025-04-01 16:11 ` Sohil Mehta
2025-04-03 13:33 ` [tip: x86/nmi] x86/nmi: Add missing description x86_platform_ops::get_nmi_reason to <asm/x86_init.h> tip-bot2 for Sohil Mehta
2025-04-03 13:33 ` [tip: x86/nmi] x86/nmi: Improve <asm/nmi.h> documentation tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 8/9] x86/nmi: Clean up NMI selftest Sohil Mehta
2025-04-03 13:33 ` [tip: x86/nmi] " tip-bot2 for Sohil Mehta
2025-03-27 23:46 ` [PATCH 9/9] x86/nmi: Improve NMI duration console print Sohil Mehta
2025-04-01 0:42 ` Huang, Kai
2025-04-03 13:33 ` [tip: x86/nmi] x86/nmi: Improve NMI duration console printouts tip-bot2 for Sohil Mehta
2025-04-01 14:54 ` [PATCH 0/9] x86: Cleanup NMI handling Peter Zijlstra
2025-04-01 16:00 ` Nikolay Borisov
2025-04-02 15:13 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01c2866-87d2-4881-9825-1b033dead5de@intel.com \
--to=sohil.mehta@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jani.nikula@intel.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox