From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC337261D for ; Sat, 1 Nov 2025 00:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761956306; cv=none; b=Gp1CnQvypuAv8VjrrCR9480Yoafn9hLDWNj7y4aPP+nT1tvX5ui/CNNZNis8zNZZvkB26uR1s2XGv5swyPlba+BSUUODkhwpqFddnesK4pZlPEMlWyhzzegt2GLGSqp12hUX2PnCbhI/9UACpvvLcATFnzOjX6uE2WfW83iWEQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761956306; c=relaxed/simple; bh=E2B3UWzG/CygJ2gZuQpAK6iCi/mmEa2MKTJf6U/VWTA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I8c6CKHe2dxufCNvqfkMfxtsS2B2jBgNGf7MZcfoWPP2rgg+MWqMgieqToqk9nQuJQzeMvWBpf7YwJeC/b5yn9GDU8Ncu70V/FcsrarLNVa6CKAmuwQU2wRMEM9JVfNMoEEAAlEQdbjY02hL1A3UAedTP/UNL0c2IySsoPBCmhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qZWnFxnY; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qZWnFxnY" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761956302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k22FrVOeT9IaUG0qE2tC6THdJ3EOujV09TCOS3UYwR4=; b=qZWnFxnYZHSW3qjVFfr6L7GSxE2+KUy0dttmdYv2x4GvR9DIEII5pmZUyzpANNA65hPoXM UsYrBHMPLN8Um/BPb0t9XQiEP5pbjG2PLkThuZQ5IIEbCBFEBJHbK4w5TAHGH4vyGyUQDK FHMPdPI2y0275DC09uVSvLxX1E5SqoU= Date: Sat, 1 Nov 2025 08:18:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 2/6] smb/server: fix return value of smb2_notify() To: Namjae Jeon Cc: sfrench@samba.org, smfrench@gmail.com, linkinjeon@samba.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> <20251017084610.3085644-3-chenxiaosong.chenxiaosong@linux.dev> <63eb1d4e-b606-4776-a0cd-d41c6bdc60be@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: ChenXiaoSong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT After I finish the other patchset, I'll fully focus on developing this feature. Thanks, ChenXiaoSong. On 11/1/25 8:10 AM, Namjae Jeon wrote: > On Sat, Nov 1, 2025 at 9:05 AM ChenXiaoSong > wrote: >> >> Hi Namjae, > Hi ChenXiaoSong, >> >> I’m referring to the userspace samba code and trying to implement this >> feature. > Sounds great! > There are requests from users to implement it : > https://github.com/namjaejeon/ksmbd/issues/495#issuecomment-3473472265 > Thanks! >> >> Thanks, >> ChenXiaoSong. >> >> On 11/1/25 7:56 AM, Namjae Jeon wrote: >>> On Fri, Oct 17, 2025 at 5:47 PM wrote: >>>> >>>> From: ChenXiaoSong >>>> >>>> smb2_notify() should return error code when an error occurs, >>>> __process_request() will print the error messages. >>>> >>>> I may implement the SMB2 CHANGE_NOTIFY response (see MS-SMB2 2.2.36) >>>> in the future. >>> Do you have any plans to implement SMB2 CHANGE_NOTIFY? >>> Thanks. >>