From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754311AbeCVBEO (ORCPT ); Wed, 21 Mar 2018 21:04:14 -0400 Received: from mga05.intel.com ([192.55.52.43]:18906 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753272AbeCVBEM (ORCPT ); Wed, 21 Mar 2018 21:04:12 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,342,1517904000"; d="scan'208";a="213744888" Subject: Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1515668586-14327-1-git-send-email-yao.jin@linux.intel.com> <20180111153028.GB20406@krava> <42a90e87-f2fd-293d-bd25-591fcdff14e1@linux.intel.com> <20180321153807.GA2707@krava> From: "Jin, Yao" Message-ID: Date: Thu, 22 Mar 2018 09:04:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180321153807.GA2707@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/2018 11:38 PM, Jiri Olsa wrote: > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: >> Hi Jiri, >> >> I'm still thinking it's worth displaying the warning when perf missing some >> libraries. >> >> Somebody just told me that perf didn't work well. While after some >> investigations, I found it's just missing some libraries when building the >> perf. >> >> But I have spent some time on getting the root cause. If with this patch, it >> should be very easily to know that. > > true.. Arnaldo, any feedback on this one? > >>> I just think it'd better provide some hints to user. For example, >>> "symbol is disabled and you need to install libelf/xxx", say something >>> like that. >>> >>> But it looks the column can't contain too much information (i.e. no more >>> space to contain the entire hints). >>> >>> Any idea? Or just add this warning in verbose mode? >>> >>>> also your change does not affect tui mode >>>> >>>> annotation for some reason does not start at all.. could be >>>> little more verbose ;-) >>>> >>>> jirka >>>> >>> >>> Yes, it doesn't affect tui mode. >>> >>> Or we just add this warning in verbose mode? >>> >>> e.g. perf report -v? > > how about displaying libraries separately with -vv output, > that would mimic the build message, like: > > $ ./perf -vv > perf version 4.16.rc6.g18fd48 > > dwarf: [ on ] > dwarf_getlocations: [ on ] > glibc: [ on ] > gtk2: [ on ] > libaudit: [ on ] > libbfd: [ on ] > libelf: [ on ] > libnuma: [ on ] > numa_num_possible_cpus: [ on ] > libperl: [ on ] > libpython: [ on ] > libslang: [ on ] > libcrypto: [ on ] > libunwind: [ on ] > libdw-dwarf-unwind: [ on ] > zlib: [ on ] > lzma: [ on ] > get_cpuid: [ on ] > bpf: [ on ] > > and perf -vvv could display the 'make VF=1' info > > jirka > I'm just afraid that the newbie will not check the -vv on his own when he gets trouble in using perf. In other words, if a user is experienced and he knows -vv yet, I may assume that he should know installing all libraries before building the perf. This patch is specific for the perf newbie. It will directly shows the error/warning when the user launches the perf binary. It will have a little bit helps, I guess. :) Thanks Jin Yao