From: Gabriel C <nix.or.die@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: e1000_netpoll() , BUG: sleeping function called from invalid context
Date: Thu, 2 Mar 2017 13:22:23 +0100 [thread overview]
Message-ID: <e02e17ea-49f7-74fe-03f1-7fcd49f8194f@gmail.com> (raw)
In-Reply-To: <dffd383c-67cc-d7f1-1d2f-8e9bd9090fa8@gmail.com>
On 02.03.2017 01:04, Gabriel C wrote:
>
>
>>> Does the patch below fix it?
>>
>> I'll test you patch in a bit and let you know.
>>
>
> It seem to work.
>
> But to be really sure I let the box running with this setup over night.
>
Also with 4.10.1 + your patch all seems fine..
The box is up 13 hours now and I cannot trigger the BUG()..
>>>
>>> 8<--------------
>>>
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -6716,19 +6716,19 @@ static irqreturn_t e1000_intr_msix(int _
>>>
>>> vector = 0;
>>> msix_irq = adapter->msix_entries[vector].vector;
>>> - disable_irq(msix_irq);
>>> + disable_hardirq(msix_irq);
>>> e1000_intr_msix_rx(msix_irq, netdev);
>>> enable_irq(msix_irq);
>>>
>>> vector++;
>>> msix_irq = adapter->msix_entries[vector].vector;
>>> - disable_irq(msix_irq);
>>> + disable_hardirq(msix_irq);
>>> e1000_intr_msix_tx(msix_irq, netdev);
>>> enable_irq(msix_irq);
>>>
>>> vector++;
>>> msix_irq = adapter->msix_entries[vector].vector;
>>> - disable_irq(msix_irq);
>>> + disable_hardirq(msix_irq);
>>> e1000_msix_other(msix_irq, netdev);
>>> enable_irq(msix_irq);
>>> }
>>>
prev parent reply other threads:[~2017-03-02 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 21:20 e1000_netpoll() , BUG: sleeping function called from invalid context Gabriel C
2017-02-17 22:38 ` Cong Wang
2017-02-17 23:16 ` Gabriel C
2017-02-17 23:24 ` Gabriel C
2017-02-17 23:25 ` Cong Wang
2017-02-17 23:38 ` Gabriel C
2017-02-17 23:44 ` Cong Wang
2017-02-17 23:53 ` Gabriel C
2017-03-01 17:13 ` Thomas Gleixner
2017-03-01 22:32 ` Gabriel C
2017-03-01 22:38 ` Thomas Gleixner
2017-03-01 22:44 ` Gabriel C
2017-03-02 0:04 ` Gabriel C
2017-03-02 12:22 ` Gabriel C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02e17ea-49f7-74fe-03f1-7fcd49f8194f@gmail.com \
--to=nix.or.die@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).