From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbdCBOvs (ORCPT ); Thu, 2 Mar 2017 09:51:48 -0500 Received: from mail-wr0-f177.google.com ([209.85.128.177]:35740 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531AbdCBOvM (ORCPT ); Thu, 2 Mar 2017 09:51:12 -0500 Subject: Re: e1000_netpoll() , BUG: sleeping function called from invalid context To: Thomas Gleixner References: <0f5cc059-3db3-f0ae-77a5-0a0c872e4874@gmail.com> <56df0620-6042-50bb-a929-2e8043369554@gmail.com> <396fbe61-daec-ff59-c9d3-f569ae55129f@gmail.com> <0d57aa09-4bf6-15d8-c398-1e5f160dbf83@gmail.com> Cc: Cong Wang , lkml , "David S. Miller" , "Peter Zijlstra (Intel)" From: Gabriel C Message-ID: Date: Thu, 2 Mar 2017 13:22:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.03.2017 01:04, Gabriel C wrote: > > >>> Does the patch below fix it? >> >> I'll test you patch in a bit and let you know. >> > > It seem to work. > > But to be really sure I let the box running with this setup over night. > Also with 4.10.1 + your patch all seems fine.. The box is up 13 hours now and I cannot trigger the BUG().. >>> >>> 8<-------------- >>> >>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c >>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c >>> @@ -6716,19 +6716,19 @@ static irqreturn_t e1000_intr_msix(int _ >>> >>> vector = 0; >>> msix_irq = adapter->msix_entries[vector].vector; >>> - disable_irq(msix_irq); >>> + disable_hardirq(msix_irq); >>> e1000_intr_msix_rx(msix_irq, netdev); >>> enable_irq(msix_irq); >>> >>> vector++; >>> msix_irq = adapter->msix_entries[vector].vector; >>> - disable_irq(msix_irq); >>> + disable_hardirq(msix_irq); >>> e1000_intr_msix_tx(msix_irq, netdev); >>> enable_irq(msix_irq); >>> >>> vector++; >>> msix_irq = adapter->msix_entries[vector].vector; >>> - disable_irq(msix_irq); >>> + disable_hardirq(msix_irq); >>> e1000_msix_other(msix_irq, netdev); >>> enable_irq(msix_irq); >>> } >>>