From: <Conor.Dooley@microchip.com>
To: <lukas.bulwahn@gmail.com>
Cc: <Daire.McNamara@microchip.com>, <linux-riscv@lists.infradead.org>,
<wsa@kernel.org>, <arnd@arndb.de>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: rectify entry for RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
Date: Thu, 11 Aug 2022 08:43:42 +0000 [thread overview]
Message-ID: <e0382547-eac1-3783-163a-600d5159feb6@microchip.com> (raw)
In-Reply-To: <962d7dce-e80e-0cf6-d346-4ae7bef892df@microchip.com>
On 11/08/2022 09:01, Conor.Dooley@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 11/08/2022 08:32, Lukas Bulwahn wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Thu, Aug 11, 2022 at 9:14 AM <Conor.Dooley@microchip.com> wrote:
>>>
>>> On 11/08/2022 08:05, Lukas Bulwahn wrote:
>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>>
>>>> Commit 3cbd67384677 ("MAINTAINERS: add the Polarfire SoC's i2c driver")
>>>> adds the file entry for drivers/i2c/busses/i2c-microchip-core.c, but the
>>>> file is actually named drivers/i2c/busses/i2c-microchip-corei2c.c.
>>>>
>>>> Repair this file reference in RISC-V/MICROCHIP POLARFIRE SOC SUPPORT.
>>>>
>>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>>> ---
>>>> Conor, please ack.
>>>
>>> FFS... Silly mistake from me there, keep getting caught out by
>>> the maintainers entries when I do an inter-version rename.
>>> Is there something I can add to my build scripts, other than the
>>> get_maintainer selftest to catch these?
>>> Thanks Lukas.
>>>
>>
>> I am not aware of another script. Why do you see the need for another one?
>>
>> I acknowledge that ./scripts/get_maintainer.pl --self-test=patterns
>> does take a few seconds (roughly 30 or so) and it checks the whole
>> MAINTAINERS file. Is that just not performant enough?
>
>
> Yeah, it takes longer than my kernel build does! If there was something
> faster I'd have added it to run every time I do a build so it'd be
> impossible to miss.
>
> It's fine, I'll just add it as a arg ;)
Ah I missed the "patterns" bit when I read this, was wondering why it was
taking so long. I'll add it in some form, so hopefully that's the end of
fixing my stuff..
next prev parent reply other threads:[~2022-08-11 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 7:05 [PATCH] MAINTAINERS: rectify entry for RISC-V/MICROCHIP POLARFIRE SOC SUPPORT Lukas Bulwahn
2022-08-11 7:14 ` Conor.Dooley
2022-08-11 7:32 ` Lukas Bulwahn
2022-08-11 8:01 ` Conor.Dooley
2022-08-11 8:43 ` Conor.Dooley [this message]
2022-08-11 10:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0382547-eac1-3783-163a-600d5159feb6@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=arnd@arndb.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lukas.bulwahn@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox