From: Krzysztof Kozlowski <krzk@kernel.org>
To: Detlev Casanova <detlev.casanova@collabora.com>,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Finley Xiao <finley.xiao@rock-chips.com>,
Jagan Teki <jagan@edgeble.ai>,
Elaine Zhang <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs
Date: Sun, 4 Aug 2024 11:56:39 +0200 [thread overview]
Message-ID: <e04258dc-07c4-45c7-90d4-bc1ed9eb100b@kernel.org> (raw)
In-Reply-To: <20240802151647.294307-3-detlev.casanova@collabora.com>
On 02/08/2024 17:14, Detlev Casanova wrote:
> From: Finley Xiao <finley.xiao@rock-chips.com>
>
> Define power domain IDs as described in the TRM.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> [reword]
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> include/dt-bindings/power/rk3576-power.h | 30 ++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 include/dt-bindings/power/rk3576-power.h
This is part of bindings.
>
> diff --git a/include/dt-bindings/power/rk3576-power.h b/include/dt-bindings/power/rk3576-power.h
Missing vendor prefix. This should be named after compatible.
> new file mode 100644
> index 0000000000000..cb33a32c1aed9
> --- /dev/null
> +++ b/include/dt-bindings/power/rk3576-power.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
Weird license.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-04 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 15:14 [PATCH 0/3] Add power-controller support for rk3576 Detlev Casanova
2024-08-02 15:14 ` [PATCH 1/3] dt-bindings: pinctrl: Add rk3576 power-controller bindings Detlev Casanova
2024-08-02 15:14 ` [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs Detlev Casanova
2024-08-04 9:56 ` Krzysztof Kozlowski [this message]
2024-08-06 16:34 ` Detlev Casanova
2024-08-08 7:54 ` Heiko Stübner
2024-08-08 16:43 ` Dragan Simic
2024-08-08 16:46 ` Heiko Stübner
2024-08-02 15:15 ` [PATCH 3/3] soc: rockchip: power-domain: Add power domain support for rk3576 Detlev Casanova
2024-08-05 1:22 ` zhangqing
2024-08-05 9:36 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04258dc-07c4-45c7-90d4-bc1ed9eb100b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox