From: Stephen Boyd <sboyd@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
agross@kernel.org, andersson@kernel.org,
linux-arm-msm@vger.kernel.org
Cc: marijn.suijten@somainline.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: gcc-sm6375: Update the .pwrsts for usb gdsc
Date: Mon, 06 Mar 2023 11:35:55 -0800 [thread overview]
Message-ID: <e04a406045121aa31762cacc02b2300d.sboyd@kernel.org> (raw)
In-Reply-To: <20230303022912.2171177-1-konrad.dybcio@linaro.org>
Quoting Konrad Dybcio (2023-03-02 18:29:11)
> The USB controller on sm6375 doesn't retain its state when the system
> goes into low power state and the GDSCs are turned off.
>
> This can be observed by the USB connection not coming back alive after
> putting the device into suspend, essentially breaking USB.
>
> Fix this by updating the .pwrsts for the USB GDSCs so they only
> transition to retention state in low power.
Is this a temporary fix? Is that why there isn't a Fixes tag? If it's a
workaround then please add a TODO comment indicating the USB driver
doesn't work properly.
next prev parent reply other threads:[~2023-03-06 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 2:29 [PATCH 1/2] clk: qcom: gcc-sm6375: Update the .pwrsts for usb gdsc Konrad Dybcio
2023-03-03 2:29 ` [PATCH 2/2] clk: qcom: gcc-msm8996: " Konrad Dybcio
2023-03-06 19:35 ` Stephen Boyd [this message]
2023-03-06 22:36 ` [PATCH 1/2] clk: qcom: gcc-sm6375: " Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04a406045121aa31762cacc02b2300d.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox