Re: [PATCH v6 11/16] PCI/AER: Check log level once and remember it

Bjorn Helgaas
2025-05-20T14:46:26Z

On Mon, May 19, 2025 at 11:17:28PM +0000, Weinan Liu wrote:
> > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> > index 315bf2bfd570..34af0ea45c0d 100644
> > --- a/drivers/pci/pcie/dpc.c
> > +++ b/drivers/pci/pcie/dpc.c
> > @@ -252,6 +252,7 @@ static int dpc_get_aer_uncorrect_severity(struct pci_dev *dev,
> > else
> > info->severity = AER_NONFATAL;
> >
> > + info->level = KERN_WARNING;
> > return 1;
> > }
>
> I think the print level should be KERN_ERR for uncorrectable errors.

Yes, thank you, fixed! dpc_get_aer_uncorrect_severity() always sets
info->severity to AER_FATAL or AER_NONFATAL, and aer_print_error()
only uses KERN_WARNING for AER_CORRECTABLE.