Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

Bjorn Helgaas
2025-05-20T13:54:03Z

On Tue, May 20, 2025 at 12:39:18PM +0300, Ilpo Järvinen wrote:
> On Mon, 19 May 2025, Bjorn Helgaas wrote:
>
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Previously the struct aer_err_info "info" was allocated on the stack
> > without being initialized, so it contained junk except for the fields we
> > explicitly set later.
> >
> > Initialize "info" at declaration so it starts as all zeroes.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/pcie/dpc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> > index df42f15c9829..fe7719238456 100644
> > --- a/drivers/pci/pcie/dpc.c
> > +++ b/drivers/pci/pcie/dpc.c
> > @@ -258,7 +258,7 @@ static int dpc_get_aer_uncorrect_severity(struct pci_dev *dev,
> > void dpc_process_error(struct pci_dev *pdev)
> > {
> > u16 cap = pdev->dpc_cap, status, source, reason, ext_reason;
> > - struct aer_err_info info;
> > + struct aer_err_info info = { 0 };
>
> = {}; is enough to initialize it, no need to add those zeros.

Changed, thank you!