Re: [PATCH v6 06/16] PCI/AER: Move aer_print_source() earlier in file

Ilpo Järvinen
2025-05-20T10:35:08Z

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

On Mon, 19 May 2025, Bjorn Helgaas wrote:

> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Move aer_print_source() earlier in the file so a future change can use it
> from aer_print_error(), where it's easier to rate limit it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/pcie/aer.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index eb42d50b2def..95a4cab1d517 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -696,6 +696,18 @@ static void __aer_print_error(struct pci_dev *dev,
> pci_dev_aer_stats_incr(dev, info);
> }
>
> +static void aer_print_source(struct pci_dev *dev, struct aer_err_info *info,
> + const char *details)
> +{
> + u16 source = info->id;
> +
> + pci_info(dev, "%s%s error message received from %04x:%02x:%02x.%d%s\n",
> + info->multi_error_valid ? "Multiple " : "",
> + aer_error_severity_string[info->severity],
> + pci_domain_nr(dev->bus), PCI_BUS_NUM(source),
> + PCI_SLOT(source), PCI_FUNC(source), details);
> +}
> +
> void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
> {
> int layer, agent;
> @@ -733,18 +745,6 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
> info->severity, info->tlp_header_valid, &info->tlp);
> }
>
> -static void aer_print_source(struct pci_dev *dev, struct aer_err_info *info,
> - const char *details)
> -{
> - u16 source = info->id;
> -
> - pci_info(dev, "%s%s error message received from %04x:%02x:%02x.%d%s\n",
> - info->multi_error_valid ? "Multiple " : "",
> - aer_error_severity_string[info->severity],
> - pci_domain_nr(dev->bus), PCI_BUS_NUM(source),
> - PCI_SLOT(source), PCI_FUNC(source), details);
> -}
> -
> #ifdef CONFIG_ACPI_APEI_PCIEAER
> int cper_severity_to_aer(int cper_severity)
> {
>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.