public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: linux-arm-kernel@lists.infradead.org
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] arm64: kexec: machine_kexec should call __flush_icache_range
Date: Mon, 30 Jul 2018 10:29:21 -0500	[thread overview]
Message-ID: <e07fc674-2a71-29ae-2212-46ee5f79593d@oracle.com> (raw)
In-Reply-To: <faf6c7cb-d9da-9a9c-cc0f-43c95e864ca2@oracle.com>

machine_kexec flushes the reboot_code_buffer from the icache
after stopping the other cpus.

Commit 3b8c9f1cdfc5 ("arm64: IPI each CPU after invalidating the I-cache
for kernel mappings") added an IPI call to flush_icache_range, which
causes a hang here, so replace the call with __flush_icache_range

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/kernel/machine_kexec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index f62effc..e8c0283 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -184,7 +184,7 @@ void machine_kexec(struct kimage *kimage)
 
 	/* Flush the reboot_code_buffer in preparation for its execution. */
 	__flush_dcache_area(reboot_code_buffer, arm64_relocate_new_kernel_size);
-	flush_icache_range((uintptr_t)reboot_code_buffer,
+	__flush_icache_range((uintptr_t)reboot_code_buffer,
 		arm64_relocate_new_kernel_size);
 
 	/* Flush the kimage list and its buffers. */
-- 
1.8.3.1


  reply	other threads:[~2018-07-30 15:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 15:28 [PATCH 0/1] arm64: for-next/core: Fix hang in machine_kexec Dave Kleikamp
2018-07-30 15:29 ` Dave Kleikamp [this message]
2018-07-30 16:16   ` [PATCH 1/1] arm64: kexec: machine_kexec should call __flush_icache_range Catalin Marinas
2018-07-30 16:22     ` Will Deacon
2018-07-30 16:39       ` Catalin Marinas
2018-07-30 16:46       ` Dave Kleikamp
2018-07-30 16:57         ` Will Deacon
2018-07-30 16:59           ` Dave Kleikamp
2018-07-30 21:36           ` Dave Kleikamp
2018-07-31  0:28             ` AKASHI Takahiro
2018-07-31  0:31               ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e07fc674-2a71-29ae-2212-46ee5f79593d@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox