From: Dave Hansen <dave.hansen@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v2 1/1] x86/cpu: Mark flag_is_changeable_p() with __maybe_unused
Date: Mon, 9 Sep 2024 08:35:43 -0700 [thread overview]
Message-ID: <e08e8add-7e4b-4a87-adb4-b6f843752bec@intel.com> (raw)
In-Reply-To: <20240905170308.260067-1-andriy.shevchenko@linux.intel.com>
On 9/5/24 10:02, Andy Shevchenko wrote:
> When flag_is_changeable_p() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> 351 | static inline int flag_is_changeable_p(u32 flag)
> | ^~~~~~~~~~~~~~~~~~~~
>
> Fix this by marking it with __maybe_unused (both cases for the sake of
> symmetry).
>
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
Maybe something like this:
http://hansen.beer/~dave/intel/onelessifdef.patch
I assume the inlines were there to suppress the "unused" warnings in the
first place. So, let's just 'use' them unconditionally and leave it up
to the compiler to figure it out.
next prev parent reply other threads:[~2024-09-09 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 17:02 [PATCH v2 1/1] x86/cpu: Mark flag_is_changeable_p() with __maybe_unused Andy Shevchenko
2024-09-09 15:35 ` Dave Hansen [this message]
2024-09-09 15:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08e8add-7e4b-4a87-adb4-b6f843752bec@intel.com \
--to=dave.hansen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox