From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f98.google.com (mail-vs1-f98.google.com [209.85.217.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DEE14ADDBD for ; Tue, 5 May 2026 17:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778002875; cv=none; b=D2DdfvgiyVf+Nz/pMVNokVfg2sNNtQl+cESKgozb6S6ACSkX2td9LCk1IcMGXK8PqAWnTqXnBrYjxuNSuTiU4sBuXg9dKZS8pe/WTeXLVWiZYOBMMwBOc0JIk7dSzaHbW95Al4DwxnLdeh2awHeYipMuSfYQ9qc25DMKDGn/mHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778002875; c=relaxed/simple; bh=GQNkioTZY8zsJN6NDokufPbM8F0jKsJOPiFzG+FzFGc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=W1v23V1zes+WPwQXGFaK08icgII+wYNe8SvED3VxV0tbzXjm8dv6wHjw0bXndIelyTFZItFdztBQLKX6EOHnsEDSMYjICWCpfRrrU0ixdqTnSuDt1qIO8Q23XwVetA9uGLOgmkGMEyJvV8eciw3L6EL7QGrdvmjMPBHNvGLCs/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XuB2gTOF; arc=none smtp.client-ip=209.85.217.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XuB2gTOF" Received: by mail-vs1-f98.google.com with SMTP id ada2fe7eead31-62e7d2633e9so106871137.0 for ; Tue, 05 May 2026 10:41:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778002872; x=1778607672; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EbBVbZQpK7Lvxj1vVsDLr4pX2aQ5pdv85p+B8cI0h8g=; b=Ix1NoM1wj3s72nh6H2N+h1sITXEZEYKx+EhE0NRExrJRaYQK6SDCZoOcdbbsMRbX2A NYZoNoJNuv/C9Impf3eGnFvTx48n7UD2rSt8jV34ueYFixnMhO/QM01Gyo8AXIgK9XJ9 OfsCVFKfS4MLpWwXGT50EjixfxV9XzUmKcXKKvFE8eaIFh3V6tqpCjUrv484QrkOoibF WatOv9CXY5uPVdOkO3tJIU7JDBzphTYRYxhf+dChTLIOqfVex5dPO9RzsIONKIqp25la MQYL+Q967G8eWqTe3YCf0kmgZuLxE9xs44sgf52PBJxhsHt+0kwR2AmWvQk0Sw4Jr97P c5vg== X-Forwarded-Encrypted: i=1; AFNElJ/LyRiwRPNKuzmB+ZpRdYECpKySRkcOKx3Mxv8kwRo3dFYkfkA7LmncPycfx8x5jWfkZi8CA66sHT+LNP0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw29dAFm6VG/aml8+UNofYwGwdLIGCrnawcLfeZALdpGk6xjRmO +Ej3NK4LZGH8uWN8cMXTiazYi8Spy8JhteeeLCfLA+XdWspY01/D2TlClmHl32USTJS3He/ylVw in7GkZKUoWvN7fg57sSqn4obmZ9EIPwCWLNzEG843T/ZOnpk33fnZYP4W1Yv1ElYck9PRkJ3SS/ 4hRMn5FQEfnYddOEflKS7RZeHOTkO2eez8aWZe3JwtAhmZLWz3P8370Z6IcPKrlJyzyA81sChot IzBFiFrP8k/1SH7CUCh3AbT X-Gm-Gg: AeBDievx5HSXtJs2bgUeBsw0kPEFd0rub4Yjte+rHS6AzdzGSIKuQR1VIFh807tIsUY SGzNXsL/UanEVmjXiwywwweWoSlyyRyhgXDRyYuLbrtsX+KErbMK71def5VpGHhWj/OptUwxxqb u8lStS55xv3WwRZg+nJ+NTQ/RaZO+gxuOWXXLlQSAB4I0Adsfa6+6+w7Ej5W34sNKzEUcHg8IQI Qr/h7+SQoHYvaSR444AkzVuTRprfKTGjOMWt8GDuHOz5H5N65c7rRs6CRLbnC7kcRKAEmwH3EnF BNFgAaqPufOrVZyr7qFJckjyn2PsQqIn0lCTHTCt1XtYhF2GuXqbhfAoZswHIObM83Z2lft3Ohj GO8iqgerygxWofK61SNKpJB7hPHONknckIbaVzWXfoAN7zN4PkGzW3lNLq9DWkhPHDs7m52W7iT Mm1+Dq19HtkNPqBSEajSLB/6gYxwhejK1Vv7tDJDggSkY9ugJMTtEk5pp8WjVGUQgUqg2mI1Oa X-Received: by 2002:a05:6102:6c2:b0:62f:4854:8c53 with SMTP id ada2fe7eead31-62f55990e89mr2563712137.12.1778002872355; Tue, 05 May 2026 10:41:12 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-16.dlp.protect.broadcom.com. [144.49.247.16]) by smtp-relay.gmail.com with ESMTPS id a1e0cc1a2514c-95ce0b9e4c8sm638134241.4.2026.05.05.10.41.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2026 10:41:12 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8d654ade33aso36658785a.1 for ; Tue, 05 May 2026 10:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1778002872; x=1778607672; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=EbBVbZQpK7Lvxj1vVsDLr4pX2aQ5pdv85p+B8cI0h8g=; b=XuB2gTOFu4eLC+LCW/k1scYfl9dKn9KB7MbyQi6A94lTps2H/rwRdQ4N5s8HoPuHgQ LiWFxlyzu/FCoABgp8d9ikTWr1TDdHFP7iRr4zyUhaQAqG9q2Us0IiEvmkKTJHWDxCDE ZCBSMNoe9ry5Bp5zSGf5CK78x91UCFeDE3tmk= X-Forwarded-Encrypted: i=1; AFNElJ+P3VbNfgJCGuuNRsy5b4KgLmEAGaSdpVjpR9t+07DeNwN/J07Eyj+KA42CvNN28KKOIq2gdhZcIh47QaE=@vger.kernel.org X-Received: by 2002:a05:620a:25c8:b0:8cd:8e8a:3584 with SMTP id af79cd13be357-902e299dd70mr664634185a.11.1778002871632; Tue, 05 May 2026 10:41:11 -0700 (PDT) X-Received: by 2002:a05:620a:25c8:b0:8cd:8e8a:3584 with SMTP id af79cd13be357-902e299dd70mr664627985a.11.1778002871100; Tue, 05 May 2026 10:41:11 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2c253259sm1372131985a.24.2026.05.05.10.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 10:41:10 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 10:41:08 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] pinctrl: bcm: Move MODULE_DEVICE_TABLE next to the table itself To: Krzysztof Kozlowski , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Linus Walleij , Ray Jui , Scott Branden , Heiko Stuebner , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260505094321.75040-3-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260505094321.75040-3-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/5/26 02:43, 'Krzysztof Kozlowski' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > By convention MODULE_DEVICE_TABLE() immediately follows the ID table it > exports, because this is easier to read and verify. It also makes more > sense since #ifdef for ACPI or OF could hide both of them. > > Most of the pin controller drivers already have this correctly placed, > so adjust the other drivers. No functional impact. > > Signed-off-by: Krzysztof Kozlowski > > --- late to the party: Reviewed-by: Florian Fainelli -- Florian