From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B492C77B7F for ; Tue, 9 May 2023 01:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233843AbjEIB4J (ORCPT ); Mon, 8 May 2023 21:56:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbjEIB4G (ORCPT ); Mon, 8 May 2023 21:56:06 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C784F5 for ; Mon, 8 May 2023 18:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683597365; x=1715133365; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=zFaFfO28Av6WuZj3Bx6g2+QHA9qzcvUC6YooF425aG8=; b=M4XK9pLQTdKmAZto2HuKQL+UKCjynRiHn58fP0OKynIuegWwmR/XVYaY A80wzmYbUE6GOoQEByUDBznWqp8DtGGq2MgYiSm+XBUR9pfmJP30PRfum p2WTNgWPkZDn5IWHFVimntzd/KlYfm45gfvD7aOL5f5kezJFVBE4ypwTP vHyCuqplJkq3nwkluMZd0zBrwqyanzUeSBnx7JeY6upSWvPDg5iMOOHHZ 0rNMRcK0rCvnfFDeTxtI0j98ZI5gah8ypOM+ksIQ4zBtVk70tCeX4Sie0 BuaqGcCdl/nHZuxJZRNFw3bgkMFEwjFDlhUFPeuNASz5NbVzQuBZQlF5e Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="351955889" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="351955889" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 18:56:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="698715887" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="698715887" Received: from allen-box.sh.intel.com (HELO [10.239.159.127]) ([10.239.159.127]) by orsmga002.jf.intel.com with ESMTP; 08 May 2023 18:56:01 -0700 Message-ID: Date: Tue, 9 May 2023 09:55:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: baolu.lu@linux.intel.com, Jason Gunthorpe , LKML , iommu@lists.linux.dev, Joerg Roedel , Jean-Philippe Brucker , Robin Murphy , Will Deacon , Raj Ashok , "Tian, Kevin" , Yi Liu , "Yu, Fenghua" , "Hansen, Dave" , Jean-Philippe Brucker Subject: Re: [PATCH] iommu: Add Kconfig help text for IOMMU_SVA Content-Language: en-US To: Jacob Pan , Linus Torvalds References: <20230506133134.1492395-1-jacob.jun.pan@linux.intel.com> <20230506150741.2e3d2dcc@jacob-builder> <20230508094014.53913cf3@jacob-builder> <20230508132130.5a6feb0b@jacob-builder> From: Baolu Lu In-Reply-To: <20230508132130.5a6feb0b@jacob-builder> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/23 4:21 AM, Jacob Pan wrote: > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index db98c3f86e8c..7106f3af74ee 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -153,9 +153,13 @@ config IOMMU_DMA > select IRQ_MSI_IOMMU > select NEED_SG_DMA_LENGTH > > +config IOMMU_MM_PASID > + bool > + > # Shared Virtual Addressing > config IOMMU_SVA > bool > + select IOMMU_MM_PASID > > config FSL_PAMU > bool "Freescale IOMMU support" > diff --git a/drivers/iommu/intel/Kconfig b/drivers/iommu/intel/Kconfig > index 2e56bd79f589..b4d7bd68a911 100644 > --- a/drivers/iommu/intel/Kconfig > +++ b/drivers/iommu/intel/Kconfig > @@ -50,6 +50,7 @@ config INTEL_IOMMU_SVM > depends on X86_64 > select MMU_NOTIFIER > select IOMMU_SVA > + select IOMMU_MM_PASID IOMMU_SVA has already selected IOMMU_MM_PASID, so there's no need to select it again here? IOMMU_SVA selects IOMMU_MM_PASID, the vt-d driver itself has no need to know about this. > help > Shared Virtual Memory (SVM) provides a facility for devices > to access DMA resources through process address space by Best regards, baolu