From: "Friday Yang (杨阳)" <Friday.Yang@mediatek.com>
To: "krzk@kernel.org" <krzk@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188
Date: Wed, 22 Jan 2025 07:39:28 +0000 [thread overview]
Message-ID: <e0aaa718aa4158cb5b276efa0529262d96db6b82.camel@mediatek.com> (raw)
In-Reply-To: <20250121-alluring-fractal-toucanet-c3b1ab@krzk-bin>
On Tue, 2025-01-21 at 11:14 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Tue, Jan 21, 2025 at 02:49:26PM +0800, Friday Yang wrote:
> > From: "friday.yang" <friday.yang@mediatek.com>
> >
> > Add 'resets' and 'reset-names' properties for SMI LARBs to support
> > SMI reset operations.
> > On the MediaTek platform, some SMI LARBs are directly connected to
> > the SMI Common, while others are connected to the SMI Sub-Common,
> > which in turn is connected to the SMI Common. The hardware block
> > diagram can be described as follows.
> >
> > SMI-Common(Smart Multimedia Interface Common)
> > |
> > +----------------+------------------+
> > | | |
> > | | |
> > | | |
> > | | |
> > | | |
> > larb0 SMI-Sub-Common0 SMI-Sub-Common1
> > | | | | |
> > larb1 larb2 larb3 larb7 larb9
> >
> > Signed-off-by: Friday Yang <friday.yang@mediatek.com>
>
> SoB/From mismatch.
>
> Please run scripts/checkpatch.pl and fix reported warnings. After
> that,
> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in
> touch
> if the warning is not clear.
>
Thanks for kindly remind, I will fix the signed name mismatch error and
check the patch again.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-01-22 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 6:49 [PATCH v3 0/2] Add SMI reset and clamp for MediaTek MT8188 SoC Friday Yang
2025-01-21 6:49 ` [PATCH v3 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 Friday Yang
2025-01-21 10:14 ` Krzysztof Kozlowski
2025-01-22 7:39 ` Friday Yang (杨阳) [this message]
2025-01-21 6:49 ` [PATCH v3 2/2] memory: mtk-smi: mt8188: " Friday Yang
2025-01-21 8:53 ` Philipp Zabel
2025-01-22 7:39 ` Friday Yang (杨阳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0aaa718aa4158cb5b276efa0529262d96db6b82.camel@mediatek.com \
--to=friday.yang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yong.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox