From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>,
Ben Brewer <ben.brewer@codethink.co.uk>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: i915 SSC Patch
Date: Fri, 29 Jul 2011 20:02:27 +0100 [thread overview]
Message-ID: <e0d58a$uf843@orsmga002.jf.intel.com> (raw)
In-Reply-To: <yunwrf1gc3b.fsf@aiko.keithp.com>
On Fri, 29 Jul 2011 11:45:28 -0700, Keith Packard <keithp@keithp.com> wrote:
Non-text part: multipart/signed
> On Fri, 29 Jul 2011 13:55:35 +0100, Ben Brewer <ben.brewer@codethink.co.uk> wrote:
>
> > I've added a global SSC (Spread Spectrum Clock) parameter to the i915
> > driver, since having SSC enabled breaks (distorts) VGA output on some
> > Core i5/i7 chips (see https://bugs.freedesktop.org/show_bug.cgi?id=38750).
> > SSC is still enabled by default so the behaviour won't change but
> > setting the global_use_ssc parameter will turn this feature off and
> > allow affected devices to function correctly (notably the Dell Vostro
> > 3300).
>
> The question I have is why is SSC enabled on the VGA output at all? I
> don't see any way VGA could ever tolerate it.
It's not meant to be and it causes havoc, from wavy/blurry output to no
sync. The other part of the patch on that bug was to walk the crtcs and
turn off SSC on the shared refclk if any output could not handle SSC. At
that point, an objection was raised that we shouldn't even be touching
the refclk if any output was currently being driven from it.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-07-29 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 12:55 i915 SSC Patch Ben Brewer
2011-07-29 18:45 ` Keith Packard
2011-07-29 19:02 ` Chris Wilson [this message]
2011-07-29 21:18 ` Keith Packard
2011-07-29 22:01 ` Gene Heskett
2011-07-29 22:18 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$uf843@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben.brewer@codethink.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox