Re: [PATCH v7 3/5] drm/ci: mediatek: add tests for powervr gpu driver

[Helen Koike <helen.koike@collabora.com>]

On 12/07/2024 06:15, Vignesh Raman wrote:
> For mediatek mt8173, the display driver is mediatek, while the
> gpu driver is powervr. Currently, in drm-ci for mt8173, only the
> display driver is tested. Add support in drm-ci to test powervr
> driver for mt8173. Powervr driver was merged in linux kernel,
> but there's no mediatek support yet. So disable the powervr:mt8173
> job which uses powervr driver.
> 
> Also update the MAINTAINERS file to include xfails for powervr driver.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
> 
> v6:
>    - New patch in the series. Split powervr changes into a new commit.
> 
> v7:
>    - No changes.
> 
> ---
>   MAINTAINERS                      |  1 +
>   drivers/gpu/drm/ci/gitlab-ci.yml |  1 +
>   drivers/gpu/drm/ci/test.yml      | 14 ++++++++++++++
>   3 files changed, 16 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f3783f2269ff..05f72eaf5267 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10778,6 +10778,7 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>   F:	Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
>   F:	Documentation/devicetree/bindings/gpu/img,powervr-sgx.yaml
>   F:	Documentation/gpu/imagination/
> +F:	drivers/gpu/drm/ci/xfails/powervr*
>   F:	drivers/gpu/drm/imagination/
>   F:	include/uapi/drm/pvr_drm.h
>   
> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
> index 9d800f629f08..ca7f873bc2d4 100644
> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
> @@ -122,6 +122,7 @@ stages:
>     - meson
>     - msm
>     - panfrost
> +  - powervr
>     - rockchip
>     - software-driver
>   
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 219eca5ef24c..86875fb96eb5 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -294,6 +294,11 @@ amdgpu:stoney:
>     variables:
>       DRIVER_NAME: mediatek
>   
> +.powervr-gpu:
> +  stage: powervr
> +  variables:
> +    DRIVER_NAME: powervr
> +
>   .panfrost-gpu:
>     stage: panfrost
>     variables:
> @@ -322,6 +327,15 @@ mediatek:mt8173:
>       - .mt8173
>       - .mediatek-display
>   
> +powervr:mt8173:
> +  extends:
> +    - .mt8173
> +    - .powervr-gpu
> +  rules:
> +    # TODO: powervr driver was merged in linux kernel, but there's no mediatek support yet
> +    # Remove the rule once mediatek support is added for powervr
> +    - when: never

well, we could leave to add it later, but I don't mind adding like this 
for now.

Acked-by: Helen Koike <helen.koike@collabora.com>

Thanks
Helen

> +
>   mediatek:mt8183:
>     extends:
>       - .mt8183