From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B16C3F2CD for ; Wed, 4 Mar 2020 15:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7165D21739 for ; Wed, 4 Mar 2020 15:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbgCDPZH convert rfc822-to-8bit (ORCPT ); Wed, 4 Mar 2020 10:25:07 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:50050 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgCDPZH (ORCPT ); Wed, 4 Mar 2020 10:25:07 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID 024FOnXA032127, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTEXMB06.realtek.com.tw[172.21.6.99]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id 024FOnXA032127 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Mar 2020 23:24:49 +0800 Received: from RTEXMB03.realtek.com.tw (172.21.6.96) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 4 Mar 2020 23:24:48 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMB03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 4 Mar 2020 23:24:48 +0800 Received: from RTEXMB04.realtek.com.tw ([fe80::d9c5:a079:495e:b999]) by RTEXMB04.realtek.com.tw ([fe80::d9c5:a079:495e:b999%6]) with mapi id 15.01.1779.005; Wed, 4 Mar 2020 23:24:48 +0800 From: Hau To: Kai-Heng Feng CC: Heiner Kallweit , Andrew Lunn , Linux Netdev List , Kernel development list , Anthony Wong , Jason Yen Subject: RE: SFP+ support for 8168fp/8117 Thread-Topic: SFP+ support for 8168fp/8117 Thread-Index: AQHVwTo87C9FPgb4q0K7N9j/9Mzg+6fW+ByAgAAXwwCAAE15gIAAfZ0AgECGEQCAAkeigIAECCeAgAQrRCCADDcng4AJ2WCQ Date: Wed, 4 Mar 2020 15:24:48 +0000 Message-ID: References: <2D8F5FFE-3EC3-480B-9D15-23CACE5556DF@canonical.com> <20200102152143.GB1397@lunn.ch> <02F7CBDE-B877-481C-A5AF-2F4CBF830A2C@canonical.com> <80E9C881-91C8-4F29-B9CE-652F9EE0B018@canonical.com> <995bddbc4f9d48cbb3a289a7e9799f15@realtek.com> <12EA7285-06D7-44D3-B033-4F52A06123CC@canonical.com> <9AAC75D4-B04F-49CD-BBB9-11AE3382E4D8@canonical.com> <5A21808E-C9DA-44BF-952B-4A5077B52E9B@canonical.com> In-Reply-To: <5A21808E-C9DA-44BF-952B-4A5077B52E9B@canonical.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Hau, > > > On Feb 19, 2020, at 22:48, Kai-Heng Feng > wrote: > > > > Hi Hau, > > > >> On Feb 19, 2020, at 22:22, Hau wrote: > > > > [snipped] > > > >> > >> Hi Kai-Heng, > >> > >> Attached file is r8168 that I have add SFP+ support for rtl8168fp. If > possible, please give it a try. > > > > I've already tested r8168 and it does support SFP+. > > > > What we are discussing here is to support this chip properly in mainline > kernel. > > > > This is what we've discussed so far: > > https://lore.kernel.org/lkml/2D8F5FFE-3EC3-480B-9D15- > 23CACE5556DF@canonical.com/ > > Is there anything you can share so we can support this chip properly in > upstream? > Hi Kai-Heng, For adding SFP+ support for rtl8168fp, 1.Some power saving features must be disabled, like APDLS/EEE/EEEPLUS... 2.PHY capability must be set to auto-negation. I am kind of busy this week. I will try to add support for this chip into upstream next week. Thanks, Hau > ------Please consider the environment before printing this e-mail.