From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05EF6C433DB for ; Thu, 14 Jan 2021 16:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB54C23B1C for ; Thu, 14 Jan 2021 16:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbhANQ52 (ORCPT ); Thu, 14 Jan 2021 11:57:28 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:1342 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbhANQ52 (ORCPT ); Thu, 14 Jan 2021 11:57:28 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 14 Jan 2021 08:56:47 -0800 Received: from [10.26.73.78] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Jan 2021 16:56:42 +0000 Subject: Re: [PATCH v1 0/5] Enable fw_devlink=on by default To: Saravana Kannan CC: Greg Kroah-Hartman , "Rafael J. Wysocki" , Android Kernel Team , LKML , Jisheng Zhang , Kevin Hilman , John Stultz , Nicolas Saenz Julienne , Marc Zyngier , linux-tegra References: <20201218031703.3053753-1-saravanak@google.com> <56f7d032-ba5a-a8c7-23de-2969d98c527e@nvidia.com> <17939709-f6f4-fa9c-836f-9779081c4087@nvidia.com> From: Jon Hunter Message-ID: Date: Thu, 14 Jan 2021 16:56:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610643407; bh=VVr9Jb7p408lN4F9Eal/RHjNNIRAMwvnH+e2NcECWK0=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=d9pC8YMLtbTPfFF6dqPv+SvrD/A4t8hzLmSYIQUpuO83iQn32eWRPj+RNpSPiJjg/ QSJg/Z2cRZq7BkQTnBerwS5Hs67qoGUU5IKpK1MzPtb0gACrLakmQod1KrKl3WPFHT QpJ+34pOIXE04LSWEom+OMajS7jRr5grOO6ShF6jZBjI700qkROlcR2krSSE6XLa00 b4gnUD8AopqIuSnzOPeRcQwo0Lmtfh/0EPjzPpcnln1J5DnhnhX74IhA+5y5oEfCel 1TcOLJuY8PALA0U6PgxRRAxawkyDOCgx2ZUMpc6nnFQ8BhkQIqFEarGy1007PvpGAZ MBTzqqV/RYjPQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/01/2021 16:47, Saravana Kannan wrote: ... >> Yes this is the warning shown here [0] and this is coming from >> the 'Generic PHY stmmac-0:00' device. > > Can you print the supplier and consumer device when this warning is > happening and let me know? That'd help too. I'm guessing the phy is > the consumer. Sorry I should have included that. I added a print to dump this on another build but failed to include here. WARNING KERN Generic PHY stmmac-0:00: supplier 2200000.gpio (status 1) The status is the link->status and looks like the supplier is the gpio controller. I have verified that the gpio controller is probed before this successfully. > So the warning itself isn't a problem -- it's not breaking anything or > leaking memory or anything like that. But the device link is jumping > states in an incorrect manner. With enough context of this code (why > the device_bind_driver() is being called directly instead of going > through the normal probe path), it should be easy to fix (I'll just > need to fix up the device link state). Correct, the board seems to boot fine, we just get this warning. Cheers Jon -- nvpublic